Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#30160 closed enhancement (fixed)

Twenty Fifteen: Improve naming and documentation of Customizer JS files

Reported by: celloexpressions's profile celloexpressions Owned by: iandstewart's profile iandstewart
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch needs-testing
Focuses: Cc:

Description

js/customizer.js is really customize-preview.js - as it runs in the Customizer preview, not the main Customizer window. Also note that all core files use customize, not customizer in filenames, although themes generally don't follow that convention. Patch renames that file and updates the docs of that and js/color-scheme-control.js (which is really more of a customizer.js type of a file, but only needs to touch color schemes) to be more precise with respect to what those files are for. I imagine the docs will be improved further in #30149.

Attachments (2)

30160.diff (3.1 KB) - added by celloexpressions 10 years ago.
Rename js/customizer.js to js/customize-preview.js and make some docs tweaks. I don't think the renaming part patched correctly.
30160.2.diff (3.2 KB) - added by celloexpressions 10 years ago.
This one should work better.

Download all attachments as: .zip

Change History (9)

@celloexpressions
10 years ago

Rename js/customizer.js to js/customize-preview.js and make some docs tweaks. I don't think the renaming part patched correctly.

@celloexpressions
10 years ago

This one should work better.

#1 @iandstewart
10 years ago

  • Milestone changed from Awaiting Review to 4.1

#2 @iandstewart
10 years ago

  • Keywords needs-testing added

#3 @iandstewart
10 years ago

With the above patch applied my local blog title and tagline are updating only in the customizer panel and not in the blog view. Pre-patch, everything is working correctly. @iamtakashi or @celloexpressions can you confirm?

#4 @iamtakashi
10 years ago

30160.2.diff works fine both in Customizer and the front to me.

#5 @celloexpressions
10 years ago

@iandstewart: may be a caching issue. Make sure customize-preview.js (from the theme) gets loaded properly in the Customizer preview iframe.

#6 @iandstewart
10 years ago

Looks like this patch is out of sync for me.

#7 @iandstewart
10 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 30271:

Twenty Fifteen: improve naming and documentation of customizer js files to match core filenaming conventions.

Props celloexpressions, fixes #30160.

Note: See TracTickets for help on using tickets.