Restoring an image when IMAGE_EDIT_OVERWRITE is true results in 'Cannot save image metadata.'

[tiqbiz]

When restoring an image (after resizing it etc.), if IMAGE_EDIT_OVERWRITE is set to true then the following condition fails (/wp-admin/includes/image-edit.php, line 622):

if ( !wp_update_attachment_metadata($post_id, $meta) || !update_post_meta( $post_id, '_wp_attachment_backup_sizes', $backup_sizes) ) {

This is because _wp_attachment_backup_sizes is already the same as $backup_sizes (update_post_meta returns false if there is no update made).

Patch attached, not 100% sure of the coding style though.

[hew]

Probably related one way or another: #30394

[azaozz]

@tiqbiz thanks for the patch. I'll tweak the coding style a bit :)

Can reproduce. Only the error message is wrong. The attachment meta is updated properly or not updated if it hasn't changed.

[azaozz]

In 31070:

Image file editor: fix a wrong error message when restoring an edited image and IMAGE_EDIT_OVERWRITE is set. Props tiqbiz, fixes #30167.