WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#30171 closed defect (bug) (fixed)

Twenty Fifteen: edit post link text can drop a line below its icon

Reported by: celloexpressions Owned by: iandstewart
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:
PR Number:

Description (last modified by celloexpressions)

Let's add white-space: nowrap; to .edit-link to avoid the edit link, which should never take up more than a line of text on any screen size anyway, from dropping a line below its icon. I don't think we can do this for any of the other post meta, as they may take up multiple lines if the author name is very long or there are a lot of categories/tags, although we may also be able to force "leave a comment" to stay on the same line with its icon (and with all three words), since that's also a known length.

Attachments (2)

30171.png (5.4 KB) - added by celloexpressions 5 years ago.
30171.diff (440 bytes) - added by iamtakashi 5 years ago.
Make sure Comments Link and Edit link stay the same line with its icon.

Download all attachments as: .zip

Change History (6)

#1 @celloexpressions
5 years ago

  • Description modified (diff)

@iamtakashi
5 years ago

Make sure Comments Link and Edit link stay the same line with its icon.

#2 @iamtakashi
5 years ago

  • Keywords has-patch added; needs-patch removed

After:

https://cldup.com/qbRr_TgzQY.png

#3 @iandstewart
5 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 4.1

#4 @iandstewart
5 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 30215:

Twenty Fifteen: Make sure that the edit link will always be right of it's icon.

Props iamtakashi, fixes #30171.

Note: See TracTickets for help on using tickets.