Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#30178 closed enhancement (fixed)

Twenty Thirteen: Replaces ellipses with ellipses and a Continue reading link.

Reported by: davidakennedy's profile davidakennedy Owned by: lancewillett's profile lancewillett
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch commit
Focuses: accessibility Cc:

Description

To help improve accessibility, we need to make clean automatically-generated excepts and excerpts handle the post title. This makes the Continue reading links more specific for screen reader users.

We should replace the ellipses (appended to automatically generated excerpts) with a Continue reading link.

We can also add a visually hidden post title in the content template parts to better accommodate screen reader users.

Something like:

<?php
    /* translators: %s: Name of current post */
    the_content( sprintf(
        esc_html__( 'Continue reading %s', 'twentyfifteen' ),
            the_title( '<span class="screen-reader-text">', '</span>', false )
        ) );
?>

Related: #30135, #30176

Attachments (2)

30178.patch (13.4 KB) - added by davidakennedy 10 years ago.
30178.2.patch (13.4 KB) - added by davidakennedy 10 years ago.
Removes leading space; concatenates ellipses with spaces and link.

Download all attachments as: .zip

Change History (10)

This ticket was mentioned in Slack in #accessibility by davidakennedy. View the logs.


10 years ago

This ticket was mentioned in Slack in #core-themes by davidakennedy. View the logs.


10 years ago

@davidakennedy
10 years ago

Removes leading space; concatenates ellipses with spaces and link.

#3 @davidakennedy
10 years ago

  • Keywords has-patch needs-testing added

This ticket was mentioned in Slack in #accessibility by davidakennedy. View the logs.


10 years ago

#5 @michaelbeil
10 years ago

  • Keywords needs-testing removed

did some testing on this patch. works well.

#6 @lancewillett
10 years ago

  • Milestone changed from Awaiting Review to 4.1

Let's try to get this in soon to coincide with updating all default themes for 4.1.

#7 @lancewillett
10 years ago

  • Keywords commit added

I adjusted the doc block and function comments a tiny bit, similar to r30389 for Twenty Fourteen.

#8 @lancewillett
10 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 30390:

Twenty Thirteen: replace ellipses appended to automatically generated excerpts with both ellipses and a "Continue Reading" link to meet accessibility-ready requirements.

Props davidakennedy, lancewillett. Fixes #30178.

Note: See TracTickets for help on using tickets.