WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#30182 closed defect (bug) (fixed)

All Iris options should be able to be overridden via wpColorPicker options

Reported by: jtsternberg Owned by: ocean90
Priority: normal Milestone: 4.1
Component: Customize Version: 3.5
Severity: normal Keywords: commit has-patch
Cc: Focuses: javascript

Description (last modified by westonruter)

'mode' and 'width' are both hard-coded in the Iris config. No reason not to allow that to be overridden via the wpColorPicker config.

Related: #29632

Attachments (1)

30182.diff​ (762 bytes ) - added by jtsternberg 12 years ago.
replace hard-coded values w/ filtered defaults

Download all attachments as: .zip

Change History (5)

@jtsternberg
12 years ago

replace hard-coded values w/ filtered defaults

#1 @jtsternberg
12 years ago

[CMB2 issue which spawned this patch](​https://github.com/WebDevStudios/CMB2/issues/60).

Version 0, edited 12 years ago by jtsternberg (next)

This ticket was mentioned in ​Slack in #core by jtsternberg. ​View the logs.
12 years ago

#3 @westonruter
12 years ago

  • Description modified (diff)
  • Focuses javascript added
  • Keywords commit has-patch added
  • Milestone Awaiting Review → 4.1
  • Version trunk → 3.5

Hard-coded values were introduced in r22385.

#4 @ocean90
12 years ago

  • Owner set to ocean90
  • Resolution → fixed
  • Status new → closed

In 30330:

Color Picker: Allow to override mode and width values for Iris via wpColorPicker options.

props jtsternberg.
fixes #30182.

Note: See TracTickets for help on using tickets.