Author page and category

[dimitrov.adrian]

Got errors like next in debug.log

PHP Notice: Undefined property: stdClass::$ID in /www/test1/wp-includes/query.php on line 4074
PHP Notice: Undefined property: stdClass::$nickname in /www/test1/wp-includes/query.php on line 4076
PHP Notice: Undefined property: stdClass::$user_nicename in /www/test1/wp-includes/query.php on line 4078

In wp-includes/query.php we have the method

public function is_author( $author = '' ) {
        if ( !$this->is_author )
            return false;

        if ( empty($author) )
            return true;

        $author_obj = $this->get_queried_object();

        $author = (array) $author;

        if ( in_array( $author_obj->ID, $author ) )
            return true;
        elseif ( in_array( $author_obj->nickname, $author ) )
            return true;
        elseif ( in_array( $author_obj->user_nicename, $author ) )
            return true;

        return false;
    }

But if we query a author page with category param queried_object actually will be the category term object, so next patch prevent such problems

public function is_author( $author = '' ) {
        if ( !$this->is_author )
            return false;

        if ( empty($author) )
            return true;

        $author_obj = $this->get_queried_object();
        
        if ( ! is_a( $author_obj, 'WP_User' ) )
            return false;

        $author = (array) $author;

        if ( in_array( $author_obj->ID, $author ) )
            return true;
        elseif ( in_array( $author_obj->nickname, $author ) )
            return true;
        elseif ( in_array( $author_obj->user_nicename, $author ) )
            return true;

        return false;
    }

[boonebgorges]

But if we query a author page with category param

How do you do this? example.com/author/boone?cat=foo?

[boonebgorges]

Related: #29660

[dimitrov.adrian]

Replying to boonebgorges:

But if we query a author page with category param

How do you do this? example.com/author/boone?cat=foo?

yes

[johnbillion]

Let's get a unit test in here please.

[johnbillion]

Also I'm not sure the current patch is correct.

is_author() on example.com/author/boone?cat=foo should return true. The problem is that the queried object for a query such as this could be either a user or a term. Which should it be?

[SirLouen]

Reproduction Report

Description

❌ This report can't validate that the issue can be reproduced.

Environment

• WordPress: 6.9-alpha-60093-src
• PHP: 8.2.28
• Server: nginx/1.27.5
• Database: mysqli (Server: 8.4.5 / Client: mysqlnd 8.2.28)
• Browser: Chrome 137.0.0.0
• OS: Windows 10/11
• Theme: Twenty Twenty-One 2.5
• MU Plugins: None activated
• Plugins:
  • Test Reports 1.2.0

Reproduction Instructions

1. According to this comment it should be reproduced by issuing something as /author/admin/?cat=foo
2. ❌ I can't see any errors in the logs
3. I've created another user just in case /author/harry/?cat=foo
4. ❌ Still can't see any errors in the logs
5. Tried triggering the double query with a real cat query author/harry/?cat=3
6. ❌ Nothing in the logs.

Actual Results

1. ❌ Error condition doesn't occur.

Additional Notes

• More information is needed to reproduce this error. needs-test-info
• Maybe it has been solved over time, so a close for worksforme could be the case now.