WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#30189 closed enhancement (fixed)

Twenty Fifteen: Use core navigation template tags

Reported by: obenland Owned by: iandstewart
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:
PR Number:

Description

r30065 introduced navigational template tags for all themes to use. They are a bit different than what we use in Twenty Fifteen, but let's use them and serve as a best practice on that regard as well.

Attachments (3)

30189.diff (8.5 KB) - added by obenland 5 years ago.
30189.1.diff (9.1 KB) - added by iamtakashi 5 years ago.
Avoid a fatal error on image.php
30189.2.diff (9.1 KB) - added by iamtakashi 5 years ago.
With consistent PHP Tag style

Download all attachments as: .zip

Change History (8)

@obenland
5 years ago

This ticket was mentioned in Slack in #core by obenland. View the logs.


5 years ago

#2 @iamtakashi
5 years ago

By looking at what you said in Slack, it might have been intentional that you left image.php untouched but

Fatal error: Call to undefined function twentyfifteen_post_nav() in .../image.php on line 73

@iamtakashi
5 years ago

Avoid a fatal error on image.php

#3 @iandstewart
5 years ago

  • Keywords commit added

#4 @obenland
5 years ago

Just noticed the patches use two different code styles regarding PHP tags between the_pagination() and the_post_navigation(). I think the former is preferred?

@iamtakashi
5 years ago

With consistent PHP Tag style

#5 @iandstewart
5 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 30216:

Twenty Fifteen: Use new core navigation tags.

Props obenland, iamtakashi, fixes #30189

Note: See TracTickets for help on using tickets.