Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 6 years ago

#30212 closed defect (bug) (fixed)

Twenty Fifteen: Proper Escaping Missing From HTML5 Shiv Header Call

Reported by: philiparthurmoore's profile philiparthurmoore Owned by: iandstewart's profile iandstewart
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:



	<!--[if lt IE 9]>
	<script src="<?php echo get_template_directory_uri(); ?>/js/html5.js"></script>

Should be this:

	<!--[if lt IE 9]>
	<script src="<?php echo esc_url( get_template_directory_uri() ); ?>/js/html5.js"></script>

Attachments (1)

30212.diff (624 bytes) - added by philiparthurmoore 9 years ago.

Download all attachments as: .zip

Change History (6)

#1 @rachelbaker
9 years ago

  • Keywords has-patch added

#2 @iandstewart
9 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 4.1

#3 @iandstewart
9 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 30218:

Twenty Fifteen: escaping for the HTML5 shiv call.

Props philiparthurmoore, fixes #30212

This ticket was mentioned in Slack in #themereview by wensolutions. View the logs.

8 years ago

This ticket was mentioned in Slack in #themereview by emiluzelac. View the logs.

6 years ago

Note: See TracTickets for help on using tickets.