#30219 closed defect (bug) (fixed)
Revisions modules should not rely on global settings
| Reported by: | ericlewis | Owned by: | wonderboymusic |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.1 |
| Component: | Revisions | Version: | |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: | javascript |
Description
Some revisions Backbone modules currently depend on the global settings object (_wpRevisionsSettings).
This is an anti-pattern and tends to make these modules non-reusable.
Attachments (2)
Change History (7)
#3
@
12 years ago
attachment:30219.2.diff supercedes attachment:30219.diff and removes all dependence on global settings.
Note:
See TracTickets
for help on using tickets.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
In attachment:30219.diff, move globally referenced initial state for
wp.revisions.model.FrameStateto initializing attributes hash.