WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#30234 closed defect (bug) (fixed)

Twenty Fifteen: Add a check if the custom color is the default of the chosen color scheme.

Reported by: iamtakashi Owned by: iandstewart
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

Currently, twentyfifteen_header_background_color_css() and twentyfifteen_sidebar_text_color_css() only check if the value is the same as the default color of the default color scheme #ffffff, #333333. This causes duplicated styles in the head when the color scheme is not the default. Also this breaks if you choose #ffffff for the sidebar color even your color scheme is dark, for example.

Attachments (1)

30234.diff (1.2 KB) - added by iamtakashi 7 years ago.
Add a check if the custom color is the default of chosen color scheme.

Download all attachments as: .zip

Change History (4)

@iamtakashi
7 years ago

Add a check if the custom color is the default of chosen color scheme.

#1 @iamtakashi
7 years ago

  • Keywords has-patch added

#2 @iandstewart
7 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 4.1

#3 @iandstewart
7 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 30221:

Twenty Fifteen: check if user-selected custom colors are the same as default so we're not duplicating styles.

Props iamtakashi, fixes #30234

Note: See TracTickets for help on using tickets.