WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#30278 closed defect (bug) (fixed)

Incorrect background color in auth check modal

Reported by: melchoyce Owned by: azaozz
Milestone: 4.2 Priority: normal
Severity: normal Version: 3.6
Component: Administration Keywords: has-patch
Focuses: ui, administration Cc:

Description

The background around the "X" is using #eee, but the modal itself uses #f1f1f1.

Attachments (4)

authcheckbg.diff (517 bytes) - added by melchoyce 6 years ago.
Screen Shot 2014-11-11 at 8.38.38 PM.png (64.1 KB) - added by melchoyce 6 years ago.
Screen Shot 2014-11-11 at 8.39.43 PM.png (21.0 KB) - added by melchoyce 6 years ago.
30278.2.diff (472 bytes) - added by valendesigns 6 years ago.

Download all attachments as: .zip

Change History (12)

#1 @valendesigns
6 years ago

  • Resolution set to invalid
  • Status changed from new to closed

The background of #wp-auth-check is #eee and the body of the login screen is #f1f1f1 which is served to the popup. However, there is a 30px padding on #wp-auth-check which means the background behind the close button is actually #eee and therefore this patch is unnecessary and makes this ticket invalid.

#2 @melchoyce
6 years ago

  • Resolution invalid deleted
  • Status changed from closed to reopened

The patch may be wrong, but the ticket isn't. There is definitely a color difference. See attached images.

#3 follow-up: @valendesigns
6 years ago

I apologize! I read your comment incorrectly before I tested your patch. You are 100% right, it is not invalid. I tested your patch and it does solve the issue. However, I think it would make more sense to just remove the background color completely so when/if the login screen background color changes this doesn't happen again.

@valendesigns
6 years ago

#4 @valendesigns
6 years ago

  • Keywords dev-feedback added

#5 @iseulde
6 years ago

  • Version changed from trunk to 3.6

#6 @valendesigns
6 years ago

Core developers, would one of you please take a look at this ticket and get it committed into 4.2?

Cheers!

#7 in reply to: ↑ 3 @azaozz
6 years ago

  • Keywords dev-feedback removed
  • Milestone changed from Awaiting Review to 4.2

Replying to valendesigns:

I think it would make more sense to just remove the background color completely so when/if the login screen background color changes this doesn't happen again.

That's not going to work. This is the same "problem" all iframe based dialogs have: the header containing the Close button is outside of the iframe. We could make is a "proper" header (similar to thickbox, etc.) but then it will look differently than most others dialogs, see the media modal for example.

Other options include matching the iframe background color, positioning the X on top of the iframe or outside the dialog box (seen this in some places, not sure it looks that good). Changing the background to f1f1f1 fixes this for now. If you want to experiment with the other options please open another ticket with screenshots, etc.

#8 @azaozz
6 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from reopened to closed

In 31022:

Fix the background color in the auth. check modal. Props melchoyce, fixes #30278.

Note: See TracTickets for help on using tickets.