WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#30286 closed enhancement (fixed)

Twenty Fifteen: embeds descender space

Reported by: afercia's profile afercia Owned by: iandstewart's profile iandstewart
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

Consider to reset the descender space below videos and other embeds, it creates an uneven bottom margin pretty evident when compared to the images bottom margin. See screenshot below.

https://cldup.com/RsHN54OCaQ.png

Attachments (1)

30286.patch​ (375 bytes) - added by afercia 11 years ago.

Download all attachments as: .zip

Change History (7)

@afercia
11 years ago

#1 @afercia
11 years ago

  • Keywords has-patch added

#2 @iamtakashi
11 years ago

Good catch! Let's get it in.

This ticket was mentioned in ​Slack in #core-themes by iandstewart. ​View the logs.
11 years ago

#4 @iandstewart
11 years ago

  • Keywords commit added

#5 @iandstewart
11 years ago

  • Milestone changed from Awaiting Review to 4.1

#6 @iandstewart
11 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 30303:

Twenty Fifteen: create consistent spacing with embeds and images.

Props afercia, fixes #30286

Note: See TracTickets for help on using tickets.