Opened 10 years ago
Closed 10 years ago
#30296 closed defect (bug) (fixed)
Twenty Fifteen: Better spacing between navigation items and their descriptions.
Reported by: | philiparthurmoore | Owned by: | iandstewart |
---|---|---|---|
Milestone: | 4.1 | Priority: | normal |
Severity: | normal | Version: | 4.1 |
Component: | Bundled Theme | Keywords: | commit has-patch |
Focuses: | Cc: |
Description
When styles are disabled menu items and their descriptions are flush (see image attachment). This proposed patch adds a space between menu items and their descriptions. I’ll say outright that I am 100% with this proposal being closed, but it feels weird to have no spaces between words like that.
Part of me would even suggest changing span
to div
here. The reason is because when spans are used there’s no good way to indicate what’s the menu item and what’s the menu item description (see image). When a div
is used there’s a line break and so you can both 1) handle the styling via CSS but also 2) make sure that when styles are disabled there’s a clear visual distinction between menu items and their descriptions.
What do you think? See the patches for potential improvements.
Attachments (6)
Change History (12)
#1
@
10 years ago
Also, block-level elements inside of links should be fine since we're using HTML5, but please do correct me if I'm wrong on that.
With DIV