wp_update_comment does not update user_id column

[jphase]

wp_update_comment() does not allow the update of the user_id column. This is caused from the $keys array on line 2233 of wp-includes/comment.php not containing the 'user_id' key before wp_array_slice_assoc() is ran on the following line. It's a very simple fix so I'll be posting a diff to this here momentarily.

Before the fix:

        $keys = array( 'comment_content', 'comment_author', 'comment_author_email', 'comment_approved', 'comment_karma', 'comment_author_url', 'comment_date', 'comment_date_gmt', 'comment_parent' );
        $data = wp_array_slice_assoc( $data, $keys );
        $rval = $wpdb->update( $wpdb->comments, $data, compact( 'comment_ID' ) );

After the fix:

        $keys = array( 'comment_content', 'comment_author', 'comment_author_email', 'comment_approved', 'comment_karma', 'comment_author_url', 'comment_date', 'comment_date_gmt', 'comment_parent', 'user_id' );
        $data = wp_array_slice_assoc( $data, $keys );
        $rval = $wpdb->update( $wpdb->comments, $data, compact( 'comment_ID' ) );

Attached is a diff for this that fixed trunk for me. Let me know if I missed something obvious or am not understanding some basic usage.

[jphase]

Diff to allow user_id to be updated through wp_update_comment()

[johnbillion]

Thanks for the patch!

[SergeyBiryukov]

Related: #30627, #30946.

[SergeyBiryukov]

In 31172:

Add 'user_id' to the list of fields wp_update_comment() can update.

props jphase.
fixes #30307.

[SergeyBiryukov]

As ​noted by ocean90, the user_id is now set to the user who edits a comment.

30307.2.patch​ should fix that.

[rachelbaker]

Tested 30307.2.patch​ successfully. Comments can be updated with the user_id set to someone other than the current user's id.

[rachelbaker]

Updated unit test to confirm user_id is not the current user.

[SergeyBiryukov]

The unit test probably doesn't need updating, since the issue here doesn't necessary have to do with the current user, but rather with unintended passing of $_POST['user_id'] to wp_update_comment() on Edit Comment screen.

[SergeyBiryukov]

Actually, not sure why there's a hidden user_id input in the first place (introduced in [658]).

edit_comment() and wp_ajax_edit_comment() don't depend on it, and it appears to be unused.

See 30307.4.patch​.

[DrewAPicture]

It would be helpful to get the fix in for not changing the user_id on edit. We're running into this issue on the WP.org Code Reference right now with edited examples (comments).

Patch still applies.

[SergeyBiryukov]

In 31776:

Remove hidden user_id input from Edit Comment screen.

Since [31172], it caused the comment's user_id field to be unexpectedly changed to the user who edits the comment.

fixes #30307.

[dllh]

The hidden field also exists on the Quick Edit form. Patch to remove it forthcoming.

[dllh]

Removes user_ID hidden field from quick edit form

[SergeyBiryukov]

Introduced in [8720], apparently as a copy/paste from edit-form-comment.php.

[SergeyBiryukov]

In 31999:

Remove hidden user_id input from wp_comment_reply().

Since [31172], it caused the comment's user_id field to be unexpectedly changed to the user who edits the comment.

See [31776] for Edit Comment screen.

props dllh.
fixes #30307.