WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#30316 closed defect (bug) (fixed)

Twenty Fifteen: color scheme labels are unclear when using a customized version

Reported by: iandstewart Owned by: iandstewart
Milestone: 4.1 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-patch
Focuses: Cc:

Description

As reported by @ryan in #29988

"Customized Twenty Fifteen. The color chooser indicates yellow, but the scheme is custom, not yellow." — Ryan

https://cldup.com/ltwkHPykb4.png

"Toggle away from yellow and toggle back to for reals see the yellow scheme." — Ryan

https://cldup.com/hFL2nEDlHe.png

Perhaps we should use "Custom" as a label instead of the color scheme? Or "Customized [Color Scheme]"?

Change History (5)

#1 @iandstewart
6 years ago

  • Summary changed from Twenty Fifteen: color scheme labels are unclear when using a customized version of them to Twenty Fifteen: color scheme labels are unclear when using a customized version

This ticket was mentioned in Slack in #core-themes by iandstewart. View the logs.


6 years ago

#3 @celloexpressions
6 years ago

Let's just change the color scheme control label to "Base Color Scheme", rather than dynamically changing the $choices labels for the different scemes.

#4 @iandstewart
6 years ago

Simple change that makes sense. I'll commit it.

#5 @iandstewart
6 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 30315:

Twenty Fifteen: since color schemes can be customized let's call them base color schemes instead of just color schemes.

Props celloexpressions, iandstewart, fixes #30316

Note: See TracTickets for help on using tickets.