WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 11 years ago

#30317 closed defect (bug) (fixed)

On setup-config page, some words are in contracted form (Short form) and some are not.

Reported by: Ankit K Gupta Owned by: DrewAPicture
Priority: normal Milestone: 4.4
Component: Text Changes Version: 1.5
Severity: minor Keywords: has-patch
Cc: Focuses: ui

Description

On setup-config page, some words are in contracted form (short form) and some are not. Should be same on a single page to maintain consistency.

Attachments (3)

contracted words.png​ (76.7 KB ) - added by Ankit K Gupta 12 years ago.
Screenshot of set up page
30317.patch​ (1.2 KB ) - added by Ankit K Gupta 12 years ago.
Patch file with updated the code
30317.diff​ (1.8 KB ) - added by iamfriendly 11 years ago.
Refreshed the patch

Download all attachments as: .zip

Change History (14)

@Ankit K Gupta
12 years ago

Screenshot of set up page

@Ankit K Gupta
12 years ago

Patch file with updated the code

#1 @Ankit K Gupta
12 years ago

  • Focuses accessibility added
  • Keywords has-patch added

#2 @ocean90
12 years ago

  • Focuses accessibility removed

#3 @juhise
12 years ago

I agree with Ankit K Gupta It should be same to keep consistency. Either use Contracted form or not.

#4 follow-up: @jeremyfelt
12 years ago

  • Component General → Text Changes
  • Version trunk → 1.5

Contractions were added in [866] to expand messaging. The original text is from [664].

#5 in reply to: ↑ 4 @Ankit K Gupta
12 years ago

Replying to jeremyfelt:

Contractions were added in [866] to expand messaging. The original text is from [664].

yeah. I m talking about same contraction rule should be apply on same page.
In first paragraph, we used doesn't, don't but in second, we used do not.

#6 @Ankit K Gupta
12 years ago

  • Component Text Changes → Administration

#7 @Ankit K Gupta
11 years ago

  • Keywords needs-refresh added
  • Severity normal → minor

@iamfriendly
11 years ago

Refreshed the patch

#8 @iamfriendly
11 years ago

  • Keywords needs-refresh removed

Refreshed the patch and also cover "does not" -> "doesn't"

#9 @SergeyBiryukov
11 years ago

  • Component Administration → Text Changes
  • Milestone Awaiting Review → 4.4

#10 @DrewAPicture
11 years ago

  • Owner set to DrewAPicture
  • Status new → reviewing

#11 @DrewAPicture
11 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 34987:

Install: Match existing tonal style in setup-config.php by converting strings containing 'do not' and 'does not' to instead use contractions.

The 'do not' is converted to "don't" because "you" is third-person plural, and 'does not' is converted to "doesn't" because localhost is third-person singular. While both are "negative" contractions, we often write this way in WordPress to provide a friendlier tone. That's your English grammar lesson for the day.

Props ankit-k-gupta, iamfriendly.
Fixes #30317.

Note: See TracTickets for help on using tickets.