WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 9 years ago

#30317 closed defect (bug) (fixed)

On setup-config page, some words are in contracted form (Short form) and some are not.

Reported by: ankit-k-gupta's profile Ankit K Gupta Owned by: drewapicture's profile DrewAPicture
Milestone: 4.4 Priority: normal
Severity: minor Version: 1.5
Component: Text Changes Keywords: has-patch
Focuses: ui Cc:

Description

On setup-config page, some words are in contracted form (short form) and some are not. Should be same on a single page to maintain consistency.

Attachments (3)

contracted words.png​ (76.7 KB) - added by Ankit K Gupta 10 years ago.
Screenshot of set up page
30317.patch​ (1.2 KB) - added by Ankit K Gupta 10 years ago.
Patch file with updated the code
30317.diff​ (1.8 KB) - added by iamfriendly 9 years ago.
Refreshed the patch

Download all attachments as: .zip

Change History (14)

@Ankit K Gupta
10 years ago

Screenshot of set up page

@Ankit K Gupta
10 years ago

Patch file with updated the code

#1 @Ankit K Gupta
10 years ago

  • Focuses accessibility added
  • Keywords has-patch added

#2 @ocean90
10 years ago

  • Focuses accessibility removed

#3 @juhise
10 years ago

I agree with Ankit K Gupta It should be same to keep consistency. Either use Contracted form or not.

#4 follow-up: @jeremyfelt
10 years ago

  • Component changed from General to Text Changes
  • Version changed from trunk to 1.5

Contractions were added in [866] to expand messaging. The original text is from [664].

#5 in reply to: ↑ 4 @Ankit K Gupta
10 years ago

Replying to jeremyfelt:

Contractions were added in [866] to expand messaging. The original text is from [664].

yeah. I m talking about same contraction rule should be apply on same page.
In first paragraph, we used doesn't, don't but in second, we used do not.

#6 @Ankit K Gupta
10 years ago

  • Component changed from Text Changes to Administration

#7 @Ankit K Gupta
9 years ago

  • Keywords needs-refresh added
  • Severity changed from normal to minor

@iamfriendly
9 years ago

Refreshed the patch

#8 @iamfriendly
9 years ago

  • Keywords needs-refresh removed

Refreshed the patch and also cover "does not" -> "doesn't"

#9 @SergeyBiryukov
9 years ago

  • Component changed from Administration to Text Changes
  • Milestone changed from Awaiting Review to 4.4

#10 @DrewAPicture
9 years ago

  • Owner set to DrewAPicture
  • Status changed from new to reviewing

#11 @DrewAPicture
9 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 34987:

Install: Match existing tonal style in setup-config.php by converting strings containing 'do not' and 'does not' to instead use contractions.

The 'do not' is converted to "don't" because "you" is third-person plural, and 'does not' is converted to "doesn't" because localhost is third-person singular. While both are "negative" contractions, we often write this way in WordPress to provide a friendlier tone. That's your English grammar lesson for the day.

Props ankit-k-gupta, iamfriendly.
Fixes #30317.

Note: See TracTickets for help on using tickets.