Hello Dolly borks "Upload Plugin" and "Upload Theme" on small screens.

[voldemortensen]

Pretty much what the title says. On smaller screens, the "Upload Plugin" and "Upload Theme" links on their respective installation pages have a funny wrap to them. Screenshots and patch to follow.

[voldemortensen]

Patch fixes the wrapping issue, but when it does wrap it causes an overlap. The "Upload Theme/Plugin" links overlap the "Add Themes/Plugins".

[5um17]

I think white-space: nowrap; is not the good solution here, making it inline-block does the job. Also if we reduce the line-height to normal it fixes the overlapping problem of Add Plugins heading.
Added patch for this.

[5um17]

Patch using inline-block

[voldemortensen]

inline-block fixed it as well, but line-height: normal did not fix the overlapping issue for me, using Firefox 33.

[5um17]

Replying to voldemortensen:

inline-block fixed it as well, but line-height: normal did not fix the overlapping issue for me, using Firefox 33.

I've also changed the padding to 5px 15px;

[5um17]

Broken text issue was fixed using white-space: nowrap; but still overlapping issue exist.
It is actually problem because a tag is inline element with top: -3px;.
Well it doesn't seems to me a good idea so I would suggest to remove top property and using inline-block with vertical alignment.

Adding patch 30343.2 for the same. I also removed top: -2px from .themes-php .wp-filter-search to make it consistence and vertically aligned with button on /wp-admin/themes.php

[5um17]

Patch to fix overlapping issue

[johnbillion]

As these 5 year old patches appear to have side effects, this isn't something that a committer is going to be interested in spending time on. There are higher priority issues to concern ourselves with.

Thanks for the patches folks but let's focus on something else.