Arrow key navigation in Media Grid skips ids

[UmeshSingla]

In grid view, on opening the attachment (Attachment Details screen ), ​http://monosnap.com/image/oUeB1PEH4elfV9dhJmNijVLAL6eENj, While using arrow keys for navigation, initially the next image loaded is proper, ​http://monosnap.com/image/DS8dJGHMN5XIH50rUftHURQqFWpd1Z, but after that it skips a id each time ​http://monosnap.com/image/M3if0DKBKBYvDF35DklfwSwobw8Ak7

To replicate:

Step - 1:

Upload some images and switch to grid view in WordPress

Step - 2:

Click over a image from grid view, which opens attachment details screen for that media. Use the right arrow key for navigation.

Step -3

On pressing right arrow key, firs time the dialog loads the proepr image, but when you press the arrow back it starts skipping the image.

[UmeshSingla]

fixes the bug in media-grid.js

[UmeshSingla]

On opening modal, this code already handles the keyDown event:
https://core.trac.wordpress.org/browser/trunk/src/wp-includes/js/media-grid.js#L441

this.modal.on( 'open', function () {
  $( 'body' ).on( 'keydown.media-modal', _.bind( self.keyEvent, self ) );
} );

And code at https://core.trac.wordpress.org/browser/trunk/src/wp-includes/js/media-grid.js#L391, registers the keyDown event again, which causes the nextMediaItem to call twice and thus skip ids.

[adamsilverstein]

regenerate patch from src, clean up inline doc description

[adamsilverstein]

@UmeshSingla - Wow, thanks for catching that! Having spent a good bit of time working on and testing keyboard navigation in the media grid, I'm embarrassed that we missed that!

I tested your patch and verified the bug exists before applying and is fixed after applying. Please note that convention is to generate diffs from the /trunk folder, makes it a bit easier to apply them :) I regenerated the patch from there and also cleaned up the language describing the keyEvent function.

Thanks again, great work!

[UmeshSingla]

@adamsilverstein, well, that's one hell of a appreciation I got ever, thanks :)

[johnbillion]

In 30377:

Avoid re-registering the keydown event controller in the media grid so arrow controls don't skip media items.

Fixes #30348
Props UmeshSingla