WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#30349 closed defect (bug) (fixed)

Admin menu gets disarranged when using tab key to navigate

Reported by: florianziegler's profile florianziegler Owned by: johnbillion's profile johnbillion
Milestone: 4.1 Priority: normal
Severity: major Version:
Component: Administration Keywords: has-patch commit
Focuses: ui, accessibility, javascript, administration Cc:

Description

When "tabbing" through the admin menu, if the browser window height is to small to fit the current (active) menu item + its submenu, they get "disarranged".

I made a screencast:

​https://cloudup.com/cWWC_qN4EO3 (14 sec)

Tested using WordPress 4.1-beta1 with Chrome 38, Chrome Canary 41.0, Firefox 34 & Safari 8.0 on Mac OS X 10.10.

Attachments (1)

30349.patch​ (497 bytes) - added by 5um17 10 years ago.
Patch to fix the issue

Download all attachments as: .zip

Change History (8)

#1 @florianziegler
10 years ago

  • Keywords needs-patch added
  • Severity changed from normal to major

#2 @florianziegler
10 years ago

  • Focuses accessibility added

This ticket was mentioned in ​Slack in #accessibility by florianziegler. ​View the logs.
10 years ago

@5um17
10 years ago

Patch to fix the issue

#4 @5um17
10 years ago

  • Keywords has-patch added; needs-patch removed

This is because adjustSubmenu function being called to adjust the top of submenu but in this case submenu is already open as this is the current menu so i guess skipping current submenu can fix this issue.
added patch for this.

#5 @florianziegler
10 years ago

Tested patch. Patch works.

#6 @johnbillion
10 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 4.1

#7 @johnbillion
10 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 30352:

Avoid adjusting the current submenu position when tabbing through the admin menu.

Fixes #30349
Props 5um17

Note: See TracTickets for help on using tickets.