WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 years ago

Last modified 21 months ago

#30353 closed defect (bug) (wontfix)

Update Hello Dolly to current standards

Reported by: pbearne Owned by:
Milestone: Priority: normal
Severity: normal Version: 2.0
Component: General Keywords: has-unit-tests has-patch
Focuses: administration Cc:

Description

The Hello Dolly plugin hasn't had any love for a while so now is not coded to current standards

Adding late esc'ing. Adding translation so translators can add a string that makes sense in that language. Added Unit testing as example. Update readme version bump

This may not be the version bundled into core but he version in plugin repo could use this

Attachments (1)

30353.patch (12.3 KB) - added by pbearne 4 years ago.
Patch for new version

Download all attachments as: .zip

Change History (18)

@pbearne
4 years ago

Patch for new version

#2 @joedolson
4 years ago

  • Focuses accessibility removed

#3 @pbearne
4 years ago

  • Keywords has-unit-tests has-patch added

#4 @nacin
4 years ago

This was done as a test ticket for WordCamp Toronto. As explained to pbearne earlier this week, this isn't something we're going to accept into core. Hello Dolly is a simple plugin, about as simple as it can get, and doesn't need any changes beyond #30120. It's still cool what could be done with it, though.

#5 @pbearne
4 years ago

it might be worth pulling out the a11n to improve usability

    $chosen = hello_dolly_get_lyric(); 
    printf( '<p id="dolly"><span class="screen-reader-text">%s </span>%s</p>', 
	 _x( 'A random lyric from Hello, Dolly by Louis Armstrong: ','hello-dolly', 'a11n aria-label' ), 
         esc_html( $chosen ) ); 

#6 @DrewAPicture
4 years ago

#30120 was marked as a duplicate.

#7 @swissspidy
3 years ago

  • Keywords close added

#8 @pbearne
3 years ago

We do need to kick matt into sorting this as it has become a joke !!

Last edited 3 years ago by pbearne (previous) (diff)

#9 @jeffmcneill
3 years ago

Can the plugin at least be removed from core? That way someone wanting to updated it could. Really this has gone on long enough, and I ain't the only one who thinks so. Make Wordpress better by removing Hello Dolly. Please. For the love of all things good.

#10 @lukecavanagh
3 years ago

Its one of the first default plugins, that you normally remove on a client dev site. Along with sample page, dummy comment and dummy post and update permalinks.

#11 @jeffmcneill
3 years ago

Yes, but there are problems it is causing that the default page, post and comment are not:

  • It is not being updated often or much, because to do so is an update to CORE which people don't want to do (see comments on tickets for hello dolly)
  • It causes problems with SVN updates if it is removed (at least in the past it has)
  • It can still exist as a plugin for people to use/test (and it would be better if that plugin were updated, to show people what a current plugin should look like), so the argument people like/want to use it, they are not being deprived
  • Unlike post/page/content it is not activated and so doesn't do anything unless enabled
  • Unlike Akismet it doesn't do anything useful

#12 @pbearne
3 years ago

I believe it is might to be the "Hello World" of plugins an example of how to create a plugin. And as such it now out of date hence the work we did on it at WordCamp Toronto

#13 @lukecavanagh
3 years ago

I agree, its the first plugin I delete on new site installs.

#14 @pento
3 years ago

  • Keywords close removed
  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed

@nacin's comment from a couple of years ago still stands - it doesn't need changes, because the point of it is to be as simple as possible. Unit tests are definitely outside of that "simple as possible" scope.

It's also not going to be removed, as it gives a very basic introduction to what the plugin screen looks like when you have a plugin installed encourages new users to see what happens when they activate a harmless plugin, and provides a bit of fun and personality to WordPress. For more adventurous users, it gives them some very simple code to delve into, learning how to create plugins for themselves.

Of course it will be removed by expert and professional WordPress developers - that's not necessarily the image you want to project when creating a client site. But there are many tools that will automatically remove it for you when you create your skeleton site, removing it from Core is wildly unnecessary for that.

#15 @jeffmcneill
3 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

The idea is not to remove the plugin from the plugin directory, but to remove it from core. None of its supposed benefits are harmed by being removed from core, and all of the problems with the plugin are in fact removed, when it is removed from core. If anyone cares about the community opinion on this, just take a browse through the reviews of this plugin. The reviews are so bad because people are forced to install this with core. https://wordpress.org/support/view/plugin-reviews/hello-dolly

If anyone were to say "Hey, let's get this plugin into core" today, everyone would laugh. However, just because it was done historically, and lives on historically, doesn't make the historical fact any more justifiable. Time to move on!

#16 @dd32
3 years ago

  • Resolution set to wontfix
  • Status changed from reopened to closed

We won't be removing it from Core, or even relegating it to the Plugin Directory only. The comments by Nacin and @pento above cover all that's needed here.

Discussion can continue without re-opening the ticket; a project lead can re-open this (or create a new ticket) if we ever decide to make a change here.

This ticket was mentioned in Slack in #polyglots by sergey. View the logs.


21 months ago

Note: See TracTickets for help on using tickets.