WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#30356 closed defect (bug) (fixed)

Focus v2: admin menu slides the wrong way with RTL

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Editor Keywords: has-patch commit
Focuses: rtl, administration Cc:
PR Number:

Description

When using RTL text direction, the admin menu still slides to the left when the focus v2 DFW kicks in.

Attachments (2)

Screen Shot 2014-11-17 at 00.52.44.png (129.6 KB) - added by johnbillion 5 years ago.
30356.diff (759 bytes) - added by yoavf 5 years ago.

Download all attachments as: .zip

Change History (7)

@yoavf
5 years ago

#1 @yoavf
5 years ago

  • Keywords has-patch added; needs-patch removed

30356.diff fixes this - not sure if there's a more elegant solution out there.

This ticket was mentioned in Slack in #core by mark. View the logs.


5 years ago

This ticket was mentioned in Slack in #core by mark. View the logs.


5 years ago

#4 @johnbillion
5 years ago

  • Keywords commit added

30356.diff works nicely and is fairly elegant.

#5 @johnbillion
5 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 30395:

Slide the admin menu out to the right when DFW mode kicks in and RTL is in use.

Fixes #30356
Props yoavf

Note: See TracTickets for help on using tickets.