Opened 10 years ago
Closed 10 years ago
#30360 closed defect (bug) (fixed)
Twenty Fifteen: links display in RTL shouldn't be inline-block"
Reported by: | yoavf | Owned by: | iandstewart |
---|---|---|---|
Milestone: | 4.1 | Priority: | normal |
Severity: | normal | Version: | 4.1 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | rtl | Cc: |
Description (last modified by )
Not sure if this is a leftover or intentional, but the following rule from rtl.css is problematic:
a { display: inline-block; }
It causes a vertical bump every time a link is hovered on, because of the bottom border:
https://cloudup.com/cCTdfSN46WD
Attachments (2)
Change History (16)
#3
in reply to:
↑ 2
;
follow-up:
↓ 7
@
10 years ago
Replying to iamtakashi:
I'm aware of I'm not testing with real RTL language though.
You should - things will just sort themselves :)
This ticket was mentioned in Slack in #core-themes by iandstewart. View the logs.
10 years ago
This ticket was mentioned in Slack in #core-themes by iandstewart. View the logs.
10 years ago
#7
in reply to:
↑ 3
;
follow-up:
↓ 8
@
10 years ago
Replying to yoavf:
You should - things will just sort themselves :)
Will it really? I'm talking about icons position and post count in the widget.
#8
in reply to:
↑ 7
@
10 years ago
- Description modified (diff)
Replying to iamtakashi:
Will it really? I'm talking about icons position and post count in the widget.
Yes. Here's ltr and rtl with the patch applied, with content in Hebrew:
#10
@
10 years ago
Oh wow, this is good to know. I really should test with a real RTL language.
If we don't need to have the style, we can remove some more styles from rtl.css. I'll work on a refresh patch.
Patch looks good to me.