WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#30360 closed defect (bug) (fixed)

Twenty Fifteen: links display in RTL shouldn't be inline-block"

Reported by: yoavf Owned by: iandstewart
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch
Focuses: rtl Cc:

Description (last modified by yoavf)

Not sure if this is a leftover or intentional, but the following rule from rtl.css is problematic:

a {
	display: inline-block;
}

It causes a vertical bump every time a link is hovered on, because of the bottom border:
https://cloudup.com/cCTdfSN46WD

Attachments (2)

30360.diff (350 bytes) - added by yoavf 6 years ago.
30360.1.diff (635 bytes) - added by iamtakashi 6 years ago.

Download all attachments as: .zip

Change History (16)

@yoavf
6 years ago

#1 @lancewillett
6 years ago

  • Keywords commit added

Patch looks good to me.

#2 follow-up: @iamtakashi
6 years ago

Without the rule, how can we deal with these stuff? I'd like to know better solution for this.

Without:
https://cldup.com/4RgoC35EgW.png

With:
https://cldup.com/KG85zMffLb.png

I'm aware of I'm not testing with real RTL language though.

#3 in reply to: ↑ 2 ; follow-up: @yoavf
6 years ago

Replying to iamtakashi:

I'm aware of I'm not testing with real RTL language though.

You should - things will just sort themselves :)

This ticket was mentioned in Slack in #core-themes by iandstewart. View the logs.


6 years ago

This ticket was mentioned in Slack in #core-themes by iandstewart. View the logs.


6 years ago

#6 @iandstewart
6 years ago

The positioning of the icons looks off to me with the patch applied.

https://cldup.com/YKydThX3B5.png

#7 in reply to: ↑ 3 ; follow-up: @iamtakashi
6 years ago

Replying to yoavf:

You should - things will just sort themselves :)

Will it really? I'm talking about icons position and post count in the widget.

#8 in reply to: ↑ 7 @yoavf
6 years ago

  • Description modified (diff)

Replying to iamtakashi:

Will it really? I'm talking about icons position and post count in the widget.

Yes. Here's ltr and rtl with the patch applied, with content in Hebrew:
https://cldup.com/ySAlTO8bjw.png

And here are the widgets with the counts:
https://cldup.com/moLVifYHvx.png

Last edited 6 years ago by yoavf (previous) (diff)

#9 @yoavf
6 years ago

  • Description modified (diff)

#10 @iamtakashi
6 years ago

Oh wow, this is good to know. I really should test with a real RTL language.

If we don't need to have the style, we can remove some more styles from rtl.css. I'll work on a refresh patch.

#11 @iandstewart
6 years ago

  • Keywords needs-refresh added; commit removed

@iamtakashi
6 years ago

#12 @iamtakashi
6 years ago

I'm having a trouble to test with a real RTL language but here is the update patch that removes some of unnecessary styles.

#13 @iamtakashi
6 years ago

  • Keywords needs-refresh removed

#14 @iandstewart
6 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 30399:

Twenty Fifteen: Removing unneeded CSS from RTL causing odd hover effects.

Props yoavf, iamtakashi, fixes #30360.

Note: See TracTickets for help on using tickets.