WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#30364 closed defect (bug) (fixed)

Destroy Sessions button accessible feedback and valid HTML

Reported by: joedolson Owned by: helen
Priority: normal Milestone: 4.1
Component: Users Version: 4.1
Severity: normal Keywords: has-patch commit
Cc: Focuses: accessibility, administration

Description

1) Notification that sessions are destroyed is not immediately announced to screen readers. Fix: add aria-live attribute to wrapping cell.

2) The destroy sessions button breaks HTML validation on submission because the JS inserts a <div> before the button, inside the wrapping <p>. Fix: change <p> to <div>.

Attachments (1)

30364.patch​ (994 bytes ) - added by joedolson 12 years ago.
Fix HTML validation & aria-live announcement

Download all attachments as: .zip

Change History (4)

@joedolson
12 years ago

Fix HTML validation & aria-live announcement

#1 @helen
12 years ago

  • Component Administration → Users
  • Focuses administration added
  • Keywords has-patch commit added
  • Milestone Awaiting Review → 4.1

Looks good to me. Leaving to johnbillion or jorbin, who worked on this and know it a little better.

This ticket was mentioned in ​Slack in #core by helen. ​View the logs.
12 years ago

#3 @helen
12 years ago

  • Owner set to helen
  • Resolution → fixed
  • Status new → closed

In 30504:

Sessions UI: Ensure screen readers provide feedback on action taken.

Also fixes some invalid HTML that occurs on DOM changes.

props joedolson.
fixes #30364.

Note: See TracTickets for help on using tickets.