WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#30364 closed defect (bug) (fixed)

Destroy Sessions button accessible feedback and valid HTML

Reported by: joedolson Owned by: helen
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Users Keywords: has-patch commit
Focuses: accessibility, administration Cc:

Description

1) Notification that sessions are destroyed is not immediately announced to screen readers. Fix: add aria-live attribute to wrapping cell.

2) The destroy sessions button breaks HTML validation on submission because the JS inserts a <div> before the button, inside the wrapping <p>. Fix: change <p> to <div>.

Attachments (1)

30364.patch​ (994 bytes) - added by joedolson 6 years ago.
Fix HTML validation & aria-live announcement

Download all attachments as: .zip

Change History (4)

@joedolson
6 years ago

Fix HTML validation & aria-live announcement

#1 @helen
6 years ago

  • Component changed from Administration to Users
  • Focuses administration added
  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 4.1

Looks good to me. Leaving to johnbillion or jorbin, who worked on this and know it a little better.

This ticket was mentioned in ​Slack in #core by helen. ​View the logs.
6 years ago

#3 @helen
6 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 30504:

Sessions UI: Ensure screen readers provide feedback on action taken.

Also fixes some invalid HTML that occurs on DOM changes.

props joedolson.
fixes #30364.

Note: See TracTickets for help on using tickets.