Manually installing language files issue

[deconf]

There is an issue while manually installing language files, to replicate follow these steps:

1. Install a new instance of WordPress and select the default option, as shown in 1.png

2. Copy the localization files in wp-content (Romanian files in this case)

3. Go to Settings -> General and select the new language (ro_RO). The WordPress install is properly localized, as you can see in 2.png

In Updates screen (see 3.png), you'll be prompted to reinstall the en_US version instead of the ro_RO or whatever.

[deconf]

Install an en_US instance

[deconf]

Settings screen

[deconf]

Updates screen

[ocean90]

#30367 was marked as a duplicate.

[ocean90]

Hello deconf,

I followed your steps but couldn't reproduce the issue, see 30369.png​. What happens when you click the "Verifică din nou" button?

[ocean90]

After switching back to en_US I could see the issue.
The update results are cached in a transient which we could delete if the WPLANG option is changed, see 30369.patch​.

[deconf]

After clicking the "Verifică din nou" button, the correct language is displayed (as shown in your attachment). Probably the transient gets updated and the correct language code is displayed.

[markoheijnen]

If wanted we can also use the new function in /wp-admin/includes/class-wp-upgrader.php where we have the same code twice.

[SergeyBiryukov]

30369.2.patch​ uses the new function in class-wp-upgrader.php as well.

[ocean90]

In 30554:

Clear update caches when site language is changed.

The update screen has a re-install button which could show the wrong language locale after the site language was changed. That's because the update data is cached.
Introduce _wp_clear_update_cache() as a helper function to clean up the update cache.

props SergeyBiryukov, ocean90.
fixes #30369.

[nacin]

In 30856:

Rename _wp_clear_update_cache() to wp_clean_update_cache().

This makes it match most cache-clearing functions, including the ones it wraps. Also no need for it to be prefixed as "private."

wp_clean_plugins_cache() doesn't always exist, so as a quick fix, clear the transient we care to clear.

see #30369.

[johnbillion]

Replying to nacin:

wp_clean_plugins_cache() doesn't always exist, so as a quick fix, clear the transient we care to clear.

wp_clean_plugins_cache() should be moved out of wp-admin/includes/plugin.php to somewhere more appropriate.

[johnbillion]

In 30870:

Rename _wp_clear_update_cache() to wp_clean_update_cache().

This makes it match most cache-clearing functions, including the ones it wraps. Also no need for it to be prefixed as "private."

wp_clean_plugins_cache() doesn't always exist, so as a quick fix, clear the transient we care to clear.

Merges [30856] to the 4.1 branch.

Fixes #30369.