wp_make_link_relative() isn't handling already relative urls

[dd32]

#30372 added a unit test to show wp_make_link_relative() working, so I took a look and spotted a few problems with the function:

• It doesn't handle schemeless url's
• It doesn't handle relative URL's with a URL in a parameter.

This example shows both failings:
var_dump( wp_make_link_relative( "//something.com/blah/blah?blah=http://example.com/ex" ) ); resulting in //something.com/blah/blah?blah=/ex

[voldemortensen]

30373.diff fixes all these issues. It also fixes #30372 and includes more comprehensive unit tests.

[voldemortensen]

#30372 was marked as a duplicate.

[boonebgorges]

voldemortensen - Thanks for the patch. Nitpick: can you separate the tests into three separate methods with more descriptive names, and put a @group 30373 annotation on the schemeless test, since that's the one actually fixed by this patch?

It looks like you are resolving the URL parameter issue with the ^ flag to mark the beginning of the string - is that right? Could you write a test for it?

[voldemortensen]

boonebgorges - made a patch with your suggestions.

[boonebgorges]

30373.patch​ fixes the annotations (sorry, I meant @ticket :) )

This looks good to me, but I'll let dd32 make the final call.

[DrewAPicture]

#30372 was marked as a duplicate.

[dd32]

Just curious why the regex was changed from // to \/\/? Other than looking more like a W, / isn't a special character in regex (As long as it's not also the delimiter, which in this case is |)

Other than that, looks good to me.

[boonebgorges]

I wondered the same thing about the unnecessary escaping. I love *W*ordPress as much as the next guy, but....

[boonebgorges]

In 30383:

Improvements to wp_make_link_relative().

• Support relative URL input.
• When the URL being made relative has another URL as a parameter, don't make the second URL relative.

Props voldemortensen.
Fixes #30373.

[DrewAPicture]

In 30496:

Add an entry to the changelog for wp_make_link_relative() noting that intentional support was added for relative URLs.

See #30373.