WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#30404 closed defect (bug) (invalid)

Twenty Fifteen: Too close to the left sidebar when using WooCommerce theme

Reported by: popf Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords:
Focuses: Cc:

Description

wordpress ver 4.1 beta1

theme twentyfifteen

woocommerce 2.2.8

http://i.imgur.com/hDhbJmf.png

too close to the left sidebar by using woocommerce theme

Attachments (1)

2015_Query_Monitor.jpg (121.7 KB) - added by pavelevap 5 years ago.

Download all attachments as: .zip

Change History (13)

#1 @pavelevap
5 years ago

Also Query Monitor output is stripped bellow :-(

This ticket was mentioned in Slack in #core by johnbillion. View the logs.


5 years ago

This ticket was mentioned in Slack in #core by deltafactory. View the logs.


5 years ago

#4 in reply to: ↑ description @deltafactory
5 years ago

Thanks for bringing this up. There's a theme compatibility issues with WooCommerce that they should address in an upcoming release. I've reported the issue here: https://github.com/woothemes/woocommerce/issues/6797

It looks like the folks at WooCommerce have needed to "massage" the markup a little for each theme, so here's another.

@pavelevap, could you provide a screenshot?

#5 @SergeyBiryukov
5 years ago

  • Component changed from General to Bundled Theme
  • Summary changed from too close to the left sidebar by using woocommerce theme to Twenty Fifteen: Too close to the left sidebar when using WooCommerce theme

#6 follow-up: @iandstewart
5 years ago

Taking a look at how WooCommerce works this doesn't look like a Twenty Fifteen issue.

https://github.com/woothemes/woocommerce/blob/master/templates/global/wrapper-start.php

It looks like WooCommerce needs WooCommerce-ready themes with WooCommerce-ready markup to Woork. And it looks like they add some custom cases in WooCommerce to support default themes and make users lives easier.

Last edited 5 years ago by iandstewart (previous) (diff)

#7 in reply to: ↑ 6 @philiparthurmoore
5 years ago

Replying to iandstewart:

...to Woork.

Not bad. ;)

#8 @pavelevap
5 years ago

Screenshot attached, Query Monitor output is hidden bellow sidebar...

#9 @deltafactory
5 years ago

@iandstewart - I've submitted the ticket mentioned above, hopefully that will get it looked at.

I agree that it's not a problem that WordPress should address but there's other discussion about handling other wide content. (Thanks for the screenshot @pavelevap.)

If it were up to me, I would use this ticket as a reminder to track the issue since it will affect users of both, and start another to track wide content issues.

#10 @iandstewart
5 years ago

The above image of the query monitor also looks like something that's outside the scope of the theme. It looks like it's injecting content into wp_footer that has no structure or style. Something that the theme can't account for. That looks like a wontfix for me but it'd be helpful to see the HTML in both cases.

As far as wide content goes, I don't see any bugs right now that are similar to this. If there are bugs they should maybe be reported in a different ticket? Wide media appears to be scaling correctly. I can make a too-wide table that will escape the post area but it'll produce an entirely different result than the issue above and isn't related. I'll make another ticket for that.

#11 @iamtakashi
5 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to invalid
  • Status changed from new to closed

I also don't think none of those is the theme issue. I suggest close this as an invalid bundle theme ticket.

#12 @jameskoster
5 years ago

I haven't looked into this yet but it's very unlikely to be a theme issue. WooCommerce includes it's own wrappers which are based on TwentyEleven (the default theme when we released 1.0).

There is logic in WooCommerce to tweak this for the other Twenty* themes but we've not addressed TwentyFifteen yet. This will be done in our next major release (2.3) which is scheduled for early next year. You can follow development of this specific issue here: https://github.com/woothemes/woocommerce/issues/6797

In the mean time, you can build this compatibility yourself into a child theme by following the information in this document: http://docs.woothemes.com/document/third-party-custom-theme-compatibility/

Alternatively you can look at using a theme that has been optimised specifically for WooCommerce such as Storefront: https://wordpress.org/themes/storefront

Cheers!

Note: See TracTickets for help on using tickets.