WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #30409, comment 12


Ignore:
Timestamp:
12/14/2014 03:56:08 AM (7 years ago)
Author:
georgestephanis
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #30409, comment 12

    initial v1  
    1 Just uploaded 30409.4.1.diff and 30409.5.1.diff -- based off the prior patches, they just move the derivative color logic into the `twentyfifteen_get_color_scheme_css` function, so only the six color scheme colors need to be passed in, rather than calculating before passing.  If they are passed, though, it will override any internal calculations.
     1Just uploaded 30409.4.1.diff and 30409.5.1.diff -- based off the prior respective patches, they just move the derivative color logic into the `twentyfifteen_get_color_scheme_css` function, so only the six color scheme colors need to be passed in, rather than calculating before passing.  If they are passed, though, it will override any internal calculations.
    22
    33Had a light discussion with @ocean90 in slack here as to this relocation of the calculations: https://wordpress.slack.com/archives/core-themes/p1418478625000200