WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#30426 closed task (blessed) (fixed)

Add Vine oEmbed support

Reported by: niallkennedy Owned by: helen
Milestone: 4.1 Priority: normal
Severity: normal Version:
Component: Embeds Keywords: has-patch commit
Focuses: Cc:
PR Number:

Description

Vine provides an oEmbed-compatible endpoint for video URLs with maxwidth and maxheight support in JSON and XML response formats. 6.5 second video loops.

From the whitelisting oEmbed providers hitlist:

Example video Ml16lZVTTxe:
https://vine.co/v/Ml16lZVTTxe
https://vine.co/oembed.json?url=https%3A%2F%2Fvine.co%2Fv%2FMl16lZVTTxe
https://vine.co/oembed.json?url=https%3A%2F%2Fvine.co%2Fv%2FMl16lZVTTxe&maxwidth=300

Attachments (1)

vine-oembed.diff (1.5 KB) - added by niallkennedy 5 years ago.
add Vine URL pattern and oEmbed endpoint. docs mention for v.next

Download all attachments as: .zip

Change History (4)

@niallkennedy
5 years ago

add Vine URL pattern and oEmbed endpoint. docs mention for v.next

#1 @helen
5 years ago

  • Keywords has-patch commit 4.2-early added
  • Milestone changed from Awaiting Review to Future Release

Announcement: https://blog.twitter.com/2014/embed-vine-videos-with-oembed
Docs: https://dev.twitter.com/web/vine/oembed

Seems good when tested (maxwidth, always SSL). Marking for 4.2-early, since we're well into 4.1 beta now.

#2 @nacin
5 years ago

  • Keywords 4.2-early removed
  • Milestone changed from Future Release to 4.1
  • Type changed from enhancement to task (blessed)

helen and I had an IRC chat with one of the people at Vine who built it. Seems solid. Handles everything I threw at it nicely. Easy win. Let's land it.

#3 @helen
5 years ago

  • Owner set to helen
  • Resolution set to fixed
  • Status changed from new to closed

In 30503:

oEmbed: Add support for the Vine endpoint.

props niallkennedy.
fixes #30426.

Note: See TracTickets for help on using tickets.