WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#30432 closed enhancement (fixed)

Twenty Fifteen: Remove custom header admin callbacks.

Reported by: philiparthurmoore Owned by: iandstewart
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

In [30459] 4.1 sends users directly to the Customizer when they want to modify their custom header. Is it okay to ditch all the twentyfifteen_admin_header_image stuff yet? If so, patch attached.

Attachments (1)

30432.diff (5.6 KB) - added by philiparthurmoore 6 years ago.

Download all attachments as: .zip

Change History (6)

This ticket was mentioned in Slack in #core-themes by philip. View the logs.


6 years ago

#2 @celloexpressions
6 years ago

+1. Users will only be able to access the old pages in the following circumstances now (mostly cases where Customizer isn't supported):

  • No JS
  • Using IE7
  • Using IE8 or IE9 on multisite with domain mapping
  • If the user has a bookmark to this screen or has a direct link here from anywhere outside core.

These cases simply aren't worth all of the complexity that this code adds to the theme from a developers' perspective. Additionally, given the sidebar/header setup in Twenty Fifteen, even with all of this code, the header "preview" is still very confusing from a UI perspective.

#3 @iamtakashi
6 years ago

Lots of red in the patch. I like it :)

#4 @iandstewart
6 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.1

#5 @iandstewart
6 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 30567:

Twenty Fifteen: remove unneeded custom header admin callbacks.

Props philiparthurmoore, fixes #30432.

Note: See TracTickets for help on using tickets.