Opened 10 years ago
Closed 3 years ago
#30439 closed feature request (wontfix)
Twenty Fourteen: Social Menu
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | normal | Version: | 4.0.1 |
Component: | Bundled Theme | Keywords: | good-first-bug has-patch needs-refresh |
Focuses: | Cc: |
Description
I would like to see native support for Social Menus in Twenty Fourteen (it's my mainstay theme for now).
I understood from the WordPress.org forums that it is built-in for the Twenty Fifteen theme. It would be great to see that in Twenty Fourteen in a future update
Thank you
Attachments (5)
Change History (26)
#1
@
10 years ago
- Component changed from Themes to Bundled Theme
- Summary changed from Social Menu for TwentyFourteen to Twenty Fourteen: Social Menu
#2
@
10 years ago
- Milestone changed from Awaiting Review to Future Release
- Priority changed from normal to low
#3
@
10 years ago
Hi lancewillett, thanks for the reply and explanation.
hmm I tried looking into my Jetpack modules but couldn't really find an option to activate the Social Menu for Twenty Fourteen.
http://kovshenin.com/2014/social-menus-in-wordpress-themes/
- I was directed to this on the WordPress.org support forums - it seems to suggest that themes should be supporting such a feature (trying to cut down my plugins bloat)
but thank you for considering this
#4
@
10 years ago
I'm fine with adding social links feature with the way Twenty Fifteen does. What we need to think about is the location. First, I thought where Further (Original theme) had: https://furtherdemo.wordpress.com/ but it would break some users header and it might not be the ideal location to add it from now. Other choices are the left sidebar (top or bottom), and the footer.
This ticket was mentioned in Slack in #core-themes by lancewillett. View the logs.
10 years ago
#6
@
10 years ago
@binarymoon is looking at this one as part of WordCamp London 2015 Contributor Day.
#8
@
9 years ago
@iamtakashi what do you think about bringing in what Twenty Sixteen does as a solution for this?
#9
@
9 years ago
As I said before, what we need to have is our consensus about the location. We need to pick the safest location. In my mind, that's either #secondary
or .site-footer
but I'm open to other suggestions.
#11
@
9 years ago
- Keywords good-first-bug added
I'd love to see a patch based on the positioning @iamtakashi is suggesting of #secondary or .site-footer.
#12
@
9 years ago
- Keywords dev-feedback added
I had a quick go at this one and have attached the results of placing the social navigation in the footer and in the sidebar.
Which one do you all prefer?
Also, the genericons version included in twentyfourteen does not have an icon for foursquare.com, it does in twentyfifteen/twentysixteen. Should we update genericons in twentyfourteen or drop the css for foursquare?
Happy to take care of the patch once we've determined where want the nav to go :)
#14
@
9 years ago
@lukecavanagh
I also agree with you to add the social icon on the footer in the right position.
#15
follow-up:
↓ 16
@
9 years ago
- Keywords has-patch added; needs-patch dev-feedback removed
I've made this into 2 patches:
- 1 that adds the menu and the styling
- 1 that updates the genericons in twentyfourteen
Testing & feedback are welcome :)
#16
in reply to:
↑ 15
@
9 years ago
Replying to janhenckens:
I've made this into 2 patches:
- 1 that adds the menu and the styling
- 1 that updates the genericons in twentyfourteen
Testing & feedback are welcome :)
When testing the patch for twenty-fourteen, the social menu looked good but I noticed a side-effect on each post's meta information (date, comments, and edit link). The font icons were unable to render due to CSS Parse issue - there was one extra trailing slash at line 3334 in the theme's stylesheet style.css. Removing the comma fixed the parse error, the patch looks ok now.
#17
@
8 years ago
- Owner set to janhenckens
- Status changed from new to assigned
Assigning ownership to mark the good-first-bug
as "claimed".
This ticket was mentioned in Slack in #core by sergey. View the logs.
5 years ago
#20
@
5 years ago
- Keywords needs-refresh added
- Milestone changed from 5.4 to Future Release
This ticket needs a refresh, and with Beta 1 closing in for 5.4, it's being moved to Future Release
. If any committer or maintainer feels this can be refreshed and reviewed in time for 5.4 or can assume ownership during a specific cycle, feel free to update the milestone accordingly.
#21
@
3 years ago
- Milestone Future Release deleted
- Resolution set to wontfix
- Status changed from assigned to closed
I'm going to close this one out as a wontfix
.
We've started to take a stance of "no new social icon requests" in other themes (see the WordPress 5.5 Theme Field Guide for Twenty Twenty). I think that should extend here to this request.
Additionally, the block editor has a growing number of social icons supported that work on any theme. Those blocks should be used instead.
Hi wilflare, thank you for the suggestion. We'll keep it in mind for a future update. For now you can use Social Menu plugin to get the same functionality, like http://jetpack.me/support/social-links/. The benefit to using a plugin is that your links will transfer if you switch themes, something not always the case if the feature is built into a theme itself.