WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#30453 closed defect (bug) (fixed)

DFW v2: fix adding of the old DFW buttons and TinyMCE's fullscreen mode

Reported by: azaozz Owned by: azaozz
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Editor Keywords: has-patch
Focuses: Cc:

Description

Assuming we are keeping the old DFW code for now but encouraging plugins that want to use it to "copy" it from core and implement it themselves. We can look at removing that code perhaps in the next WordPress version.

Plugins should be able to add the old DFW buttons easily, both for the "main" editor and for other instances. Also there are bugs when using the TinyMCE's fullscreen plugin in the "main" editor.

Attachments (1)

30453.patch (6.3 KB) - added by azaozz 6 years ago.

Download all attachments as: .zip

Change History (5)

@azaozz
6 years ago

#1 @azaozz
6 years ago

  • Keywords has-patch added

In 30453.patch:

  • Add CSS reset for the TinyMCE's fullscreen mode when used on the Edit Post screen.
  • Fix loading of the new/old DFW's buttons, use another arg. passed to WP_Editors.
  • Reset editor-expand when exiting TinyMCE's fullscreen mode.

#2 @azaozz
6 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 30573:

Editor:

  • Add CSS reset for the TinyMCE fullscreen mode when used on the Edit Post screen.
  • Fix loading of the old and new DFW buttons, use another arg. passed to WP_Editors.
  • Reset editor-expand when exiting TinyMCE fullscreen mode.

Fixes #30453.

#3 @azaozz
6 years ago

In 30583:

Editor: fix warnings in class-wp-editor.php, see #30453.

#4 @azaozz
6 years ago

In 30594:

Editor: move the DFW v2 transitions CSS from editor.css to wp-admin.css. They are needed only on the Edit Post screen.
See #30453.

Note: See TracTickets for help on using tickets.