Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 12 years ago

Closed 12 years ago

#30455 closed defect (bug) (fixed)

Make the Big5 unit tests works

Reported by:	akumria	Owned by:	boonebgorges
Priority:	normal	Milestone:	4.1
Component:	Formatting	Version:	4.1
Severity:	normal	Keywords:
Cc:		Focuses:

Description

The current Big5 unittests are marked as "Incomplete".

The listed reason was that no assertions were made.

The following patches:

fix some whitespace issues
load the test data
test against that data (i.e. does some assertions)

I have also attached an updated big5.txt files:

the original was *NOT* in Big5
this is from Wikipedia (https://en.wikipedia.org/wiki/Big5)
specifically http://ftp.isu.edu.tw/pub/Windows/Chinese/font/chinasea/csw10_exp.txt
I have removed the majority of that file and reduced the number of strings to 5 (to match the number in tests/phpunit/data/formatting/utf-8/utf-8.txt)

Attachments (4)

big5.txt (30 bytes ) - added by akumria 12 years ago.: 5 Big5 strings
0001-whitespace-fix.patch (898 bytes ) - added by akumria 12 years ago.: whitespace fix
0002-Actually-read-the-big5-strings-and-return-them.patch (972 bytes ) - added by akumria 12 years ago.: read in the Big5 data
0003-Actually-perform-a-test-against-the-string.patch (1000 bytes ) - added by akumria 12 years ago.: Test Big5 strings

Download all attachments as: .zip

Change History (7)

@akumria
12 years ago

Attachment big5.txt added

5 Big5 strings

@akumria
12 years ago

Attachment 0001-whitespace-fix.patch added

whitespace fix

@akumria
12 years ago

Attachment 0002-Actually-read-the-big5-strings-and-return-them.patch added

read in the Big5 data

@akumria
12 years ago

Attachment 0003-Actually-perform-a-test-against-the-string.patch added

Test Big5 strings

This ticket was mentioned in Slack in #core by akumria. View the logs.

12 years ago

#2 @boonebgorges
12 years ago

Milestone Awaiting Review → 4.1

This looks good, thanks! Looking forward to getting rid of that annoying yellow "I" :)

#3 @boonebgorges
12 years ago

Owner set to boonebgorges
Resolution → fixed
Status new → closed

Repair the seems_utf8() tests that use Big5 encoding.

Provide sample data that is actually encoded in Big5.
Do some actual assertions against that data.

Props akumria.
Fixes #30455.

Note: See TracTickets for help on using tickets.

Download in other formats: