WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#30455 closed defect (bug) (fixed)

Make the Big5 unit tests works

Reported by: akumria Owned by: boonebgorges
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Formatting Keywords:
Focuses: Cc:

Description

The current Big5 unittests are marked as "Incomplete".

The listed reason was that no assertions were made.

The following patches:

  • fix some whitespace issues
  • load the test data
  • test against that data (i.e. does some assertions)

I have also attached an updated big5.txt files:

Attachments (4)

big5.txt (30 bytes) - added by akumria 5 years ago.
5 Big5 strings
0001-whitespace-fix.patch (898 bytes) - added by akumria 5 years ago.
whitespace fix
0002-Actually-read-the-big5-strings-and-return-them.patch (972 bytes) - added by akumria 5 years ago.
read in the Big5 data
0003-Actually-perform-a-test-against-the-string.patch (1000 bytes) - added by akumria 5 years ago.
Test Big5 strings

Download all attachments as: .zip

Change History (7)

@akumria
5 years ago

5 Big5 strings

@akumria
5 years ago

whitespace fix

This ticket was mentioned in Slack in #core by akumria. View the logs.


5 years ago

#2 @boonebgorges
5 years ago

  • Milestone changed from Awaiting Review to 4.1

This looks good, thanks! Looking forward to getting rid of that annoying yellow "I" :)

#3 @boonebgorges
5 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 30525:

Repair the seems_utf8() tests that use Big5 encoding.

  • Provide sample data that is actually encoded in Big5.
  • Do some actual assertions against that data.

Props akumria.
Fixes #30455.

Note: See TracTickets for help on using tickets.