WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#30458 closed task (blessed) (fixed)

Add a pointer for the new DFW

Reported by: azaozz Owned by: azaozz
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Editor Keywords:
Focuses: ui Cc:

Description

Looks like we will have to retire the wp360_revisions pointer as it covers the DFW button. For people upgrading from WordPress < 3.5, there will be two pointers on the Add/Edit Post screen, this one and wp350_media.

Attachments (5)

30458.patch (2.4 KB) - added by azaozz 5 years ago.
dfw-pointer.png (71.2 KB) - added by azaozz 5 years ago.
Add New Post screen after updating from < 3.5.
30458.2.patch (3.1 KB) - added by azaozz 5 years ago.
dfw-pointer-2.png (64.5 KB) - added by azaozz 5 years ago.
Screenshot 2014-12-03 21.58.06.png (102.1 KB) - added by johnbillion 5 years ago.

Download all attachments as: .zip

Change History (31)

@azaozz
5 years ago

#1 @azaozz
5 years ago

In 30458.patch:

  • Retire the 3.6 revisions pointer.
  • Add 4.1 DFW pointer.

TO-DO: refine the text and change it if we are shipping new DFW enabled by default.

@azaozz
5 years ago

Add New Post screen after updating from < 3.5.

This ticket was mentioned in Slack in #feature-focus by azaozz. View the logs.


5 years ago

#3 @johnbillion
5 years ago

We can't have two pointers at once on the same screen.

#4 @iseulde
5 years ago

Did anyone notice the way Slack handles multiple pointers? I really like that. :)

#6 @azaozz
5 years ago

In 30458.patch the two pointers will be shown only for users upgrading from WordPress <= 3.4 to 4.1+. For everybody else, including new installs, only the DFW pointer will be shown.

In current trunk we still have two pointers on that screen: wp350_media and wp360_revisions, shown for users upgrading from <= 3.4 to 3.6+.

If we are retiring the wp350_media pointer, we can position the DFW pointer to the left of the button, covering the editor toolbar. Would be better on small screens.

Last edited 5 years ago by azaozz (previous) (diff)

@azaozz
5 years ago

#7 @azaozz
5 years ago

In 30458.2.patch: also remove the wp350_media pointer and position the DFW pointer to the left of the button.

Last edited 5 years ago by azaozz (previous) (diff)

@azaozz
5 years ago

#8 @azaozz
5 years ago

  • Focuses ui added
  • Keywords has-patch added

#9 @azaozz
5 years ago

In 30574:

Editor: add a pointer for the new DFW button. Remove the wp350_media and wp360_revisions pointers from the same screens. See #30458.

#10 @azaozz
5 years ago

Leaving this open for now to review the exact pointer text.

#11 @johnbillion
5 years ago

  • Type changed from defect (bug) to task (blessed)

Text definitely needs updating, especially if we switch to this being disabled by default.

#12 @kpdesign
5 years ago

A few minor tweaks?

Enable distraction-free writing - everything fades away so you can focus. Move your mouse out of the editor to bring the admin back. Start typing, and the admin fades away again.

#13 follow-up: @johnbillion
5 years ago

Even more concise:

Enable distraction-free writing - start typing and everything fades away so you can focus. Move your mouse out of the editor to bring the admin back again.

I'm not keen on the word "admin". Any better suggestions?

#14 in reply to: ↑ 13 ; follow-up: @DrewAPicture
5 years ago

Replying to johnbillion:

I'm not keen on the word "admin". Any better suggestions?

Maybe something like this:

Move your mouse out of the editor to reveal the writing tools again.

Still doesn't read very well. It's probably because we've generalized with "everything" in the first sentence so it's tough to be specific when you're coming back to it.

#15 @azaozz
5 years ago

In 30641:

Editor: no pointer for DFW v2 when editor-scrolling is not used. Pass $post_type in the wp_editor_expand filter. See #30458.

#16 @DrewAPicture
5 years ago

In 30643:

Add an entry to the changelog for the wp_editor_expand hook denoting that the $post_type parameter was added in 4.1.0.

See #30458.

#17 in reply to: ↑ 14 @kpdesign
5 years ago

Replying to DrewAPicture:

Maybe something like this:

Move your mouse out of the editor to reveal the writing tools again.

Still doesn't read very well. It's probably because we've generalized with "everything" in the first sentence so it's tough to be specific when you're coming back to it.

Maybe this?

Enable distraction-free writing - start typing, and other writing tools fade away so you can focus. Move your mouse out of the editor to reveal everything again.

#18 @azaozz
5 years ago

There is another problem. DFW v2 is only available when editor-expand is on. When it is off the "Fullscreen" button in disabled and greyed out. There is no indication how to enable it/make it work. Perhaps that should be mentioned in the pointer. Also see #30557.

#19 @kpdesign
5 years ago

@azaozz: What about:

Distraction-free writing - start typing, and the other elements fade away so you can focus. Move your mouse out of the editor to reveal everything again. Enable it with two clicks - one in Screen Options, and another one here.

I left a comment on #30557, along with a patch.

#20 @azaozz
5 years ago

Thanks @kpdesign. Opened #30568 to hide the DFW button when the user has turned editor-expand off.

#21 @azaozz
5 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 30717:

Update the DFW v2 pointer text. Props kpdesign, DrewAPicture, johnbillion. Fixes #30458.

#22 @johnbillion
5 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

The pointer doesn't show up if you've disabled the visual editor from your profile screen, although DFW still functions in this case.

#23 @johnbillion
5 years ago

  • Keywords needs-patch added; has-patch removed

#24 @azaozz
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 30730:

Editor show the DFW v2 pointer for users that have disabled the visual editor. Fixes #30458.

#25 @johnbillion
5 years ago

  • Keywords needs-patch removed

The image above is a screenshot of the post editing screen with the DFW admin pointer. It suggests that starting to type will trigger DFW, but the cursor is currently in the title field so this isn't the case.

Can we delay the admin pointer so it only appears once focus enters the editor?

#26 @azaozz
5 years ago

Can we delay the admin pointer so it only appears once focus enters the editor?

Not with the current pointers. This would need some more JS and there isn't a good place for it. The only place seems to be in the pointer "registration" functions, but will need to add some logic that would output raw JS. Then we would need to remember to keep it updated as it will depend on other JS APIs.

Note: See TracTickets for help on using tickets.