WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#30479 closed defect (bug) (fixed)

Twenty Fifteen: class="says" has style defined as display: none, should be like screen-reader-only

Reported by: rianrietveld Owned by: iandstewart
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch commit
Focuses: accessibility Cc:

Description

In wp-includes/comment-template.php the class="says" is added to hide text from screen.

Twenty Fifteen defines that as

.says {
	display: none;
}

Display: none; also hides text from screen readers, so it's not useful to do so.

It would be better if that was defined as or like screen-reader-text.

Is there a way to solve this like @mattwiebe did in #30110?

Attachments (1)

30479-hide-says.diff (545 bytes) - added by iandstewart 6 years ago.
a11y-ready hiding of "says:" in comments

Download all attachments as: .zip

Change History (7)

#1 @helen
6 years ago

  • Milestone changed from Awaiting Review to 4.1

#2 @iamtakashi
6 years ago

Or apply .says the same style as .screen-reader-text ?

@iandstewart
6 years ago

a11y-ready hiding of "says:" in comments

#3 @iandstewart
6 years ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #core-themes by iandstewart. View the logs.


6 years ago

#5 @iandstewart
6 years ago

  • Keywords commit added

@davidakennedy did a quick review of the above. Looks good. Committing.

#6 @iandstewart
6 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 30570:

Twenty Fifteen: make sure the 'says:' in comments is readable by a screen-reader.

Fixes #30479.

Note: See TracTickets for help on using tickets.