WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 7 years ago

#3049 closed defect (bug) (fixed)

wrong class attribution for wp_list_pages when author template is called...

Reported by: tripleshift Owned by:
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.0.4
Component: Template Keywords: wp_list_pages, current_list_item, author.php
Focuses: Cc:

Description

i recently came across this issue while studing the wordpress template system and functions.

if i got it right, "wp_list_pages" function is supposed to give a "current_page_item" class to the list item whose page is actually called.

i noticed that when the author.php template is called through "the_author_posts_link" function, and the ID of the user/author called is the same of one of the pages, the page list item generated by "wp_list_pages" gets the "current_page_item" class as well.

example:
user "john doe" with "id=3" has 3 posts and through a link generated by "the_author_posts_link" (put inside the loop) gets his post listed in a page generated through the auhtor.php template.

if the condition exists that one of the existent pages (listed by "wp_list_pages") has id="3" (the same as the user/author), then a "current_page_item" class is given to the list item containing the link to the page, even if the page IS NOT "current".

i truly hope what i wrote was clear, i truly hope i didn't file an already existent report.

bye
tripleshift

...

Change History (11)

comment:1 ryan7 years ago

  • Milestone set to 2.1.1

comment:2 ryan7 years ago

Does the same with categories.

comment:3 ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4863]) Check page ID only if is_page. fixes #3049

comment:4 ryan7 years ago

(In [4864]) Check page ID only if is_page. fixes #3049

comment:5 ryan7 years ago

  • Milestone changed from 2.1.1 to 2.0.9
  • Resolution fixed deleted
  • Status changed from closed to reopened

Fixed for 2.1.1 and 2.2. Leaving open for 2.0.9 consideration.

comment:6 Nazgul7 years ago

  • Milestone changed from 2.0.9 to 2.0.10

2.0.9 is out, so bumping the milestone to 2.0.10.

comment:7 foolswisdom7 years ago

  • Milestone changed from 2.0.10 to 2.0.11

comment:8 foolswisdom7 years ago

  • Milestone changed from 2.0.11 to 2.0.eventually

comment:9 Nazgul7 years ago

  • Milestone 2.0.eventually deleted
  • Resolution set to wontfix
  • Status changed from reopened to closed

Closing as wontfix for the 2.0 branch.

MarkJaquith has stated that only security fixes can go into the 2.0 branch.

comment:10 foolswisdom7 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

comment:11 foolswisdom7 years ago

  • Milestone set to 2.1
  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.