WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#30500 closed defect (bug) (fixed)

html output in comment-template.php

Reported by: timersys Owned by: wonderboymusic
Milestone: 4.2 Priority: normal
Severity: normal Version: 3.0
Component: Comments Keywords: has-patch 4.2-early
Focuses: template Cc:
PR Number:

Description

If you add function to the init hook to set cookies you will get an error because output already started in comment-template.php

Attached is a patch

Attachments (1)

#30500.diff (515 bytes) - added by timersys 5 years ago.
removed html space

Download all attachments as: .zip

Change History (5)

@timersys
5 years ago

removed html space

#1 @jeremyfelt
5 years ago

  • Component changed from General to Comments
  • Milestone changed from Awaiting Review to Future Release
  • Version changed from trunk to 3.0

Hi @timersys, thanks for the report and the patch. This makes sense, it looks like the extra space has been there since the introduction of the standard comment form in #10910.

#2 @SergeyBiryukov
5 years ago

  • Keywords has-patch 4.2-early added

#3 @wonderboymusic
5 years ago

  • Milestone changed from Future Release to 4.2

#4 @wonderboymusic
5 years ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 31036:

Remove whitespace side effects from comment_form().

Props timersys.
Fixes #30500.

Note: See TracTickets for help on using tickets.