WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#30507 closed defect (bug) (fixed)

Remove wrong param from gallery_style filter inline docblock.

Reported by: keesiemeijer Owned by: DrewAPicture
Milestone: 4.1 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch
Focuses: docs Cc:

Description

This is a follow-up to #27718.

The filter 'gallery_style' in wp-includes/media.php has a wrong parameter $gallery_div in the inline docblock.

https://core.trac.wordpress.org/browser/tags/4.0/src/wp-includes/media.php#L1053

Attachments (1)

30507.diff (565 bytes) - added by keesiemeijer 6 years ago.

Download all attachments as: .zip

Change History (5)

@keesiemeijer
6 years ago

#1 @keesiemeijer
6 years ago

  • Keywords has-patch added

#2 @DrewAPicture
6 years ago

  • Milestone changed from Awaiting Review to 4.1
  • Version 3.9 deleted

Hi Keesie, thanks for the patch!

For future reference, it's helpful if you generate patches from the project root instead of directly against the changed file(s).

#3 @DrewAPicture
6 years ago

  • Owner set to DrewAPicture
  • Resolution set to fixed
  • Status changed from new to closed

In 30635:

Remove an invalid parameter from the DocBlock for the gallery_style hook.

Props keesiemeijer.
Fixes #30507.

#4 @keesiemeijer
6 years ago

Thanks, I didn't know that. I'll make sure to do that next time.

Note: See TracTickets for help on using tickets.