WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#30510 closed defect (bug) (fixed)

Autosave notice is awkward when using DFW

Reported by: voldemortensen's profile voldemortensen Owned by:
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Editor Keywords: 2nd-opinion has-patch
Focuses: ui Cc:

Description

When there is an autosave notice and DFW is enabled, it looks very awkward. Screenshot to follow.

Attachments (2)

awkward-notice.jpg​ (112.6 KB) - added by voldemortensen 11 years ago.
30510.patch​ (593 bytes) - added by iseulde 11 years ago.

Download all attachments as: .zip

Change History (7)

@voldemortensen
11 years ago

#1 @johnbillion
11 years ago

  • Component changed from General to Editor
  • Focuses ui added
  • Keywords 2nd-opinion added
  • Milestone changed from Awaiting Review to 4.1

I think this is probably desired behaviour. The autosave message is intended to prevent people from losing content, so leaving it in place when DFW kicks in is fine.

#2 @voldemortensen
11 years ago

I'm fine with it staying. It just looks very bad to have it stick so far out to the right. Maybe it could shrink to match the width of the editor?

#3 @Ipstenu
11 years ago

We'd have to have a check to see if DFW was active or not, since the full width makes sense when it's off.

DFW on: Editor Width

DFW off: Full width

@iseulde
11 years ago

#4 @iseulde
11 years ago

  • Keywords has-patch added

That's because the classes changed in [30505]. This actually wasn't the intention.

#5 @johnbillion
11 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r30594.

Note: See TracTickets for help on using tickets.