WP_Dependencies::recurse_deps can recurse infinitely

[ccomp5950]

Script dependencies can recurse infinitely (unto memory exhaustion, etc.)

​http://i.imgur.com/uVHDCpX.png

Patch attached, sets a maximum depth and when it is reached stops recursion.

[wonderboymusic]

Thanks for the report - can you provide the code called in WC_Frontend_Scripts? I am curious what triggers this recursion on your end.

[ccomp5950]

Hi,

The code is from woo-commerce I believe, I can check back with the customer. (I work for their hosting company and after they threw their hands in the air asked us to take a look at it, diagnosing stuff like this is outside the scope of our managed services agreement but I like a challenge so took a look at it)

It's been nearly a month so I'm not sure, and since it was a demonstration site chances are it wasn't ever added to the backup system.

[ccomp5950]

​http://privatepaste.com/d21ada3825

is the code.

[SergeyBiryukov]

#29622 was marked as a duplicate.

[boonebgorges]

Thanks for the report. Using a depth counter like this seems like a sorta hackish workaround that has the potential to cause problems with legitimately complex dependencies. How about doing some actual loop detection? Like maybe recurse_deps() should accept a third param that is a flat array of unique handles identified in the tree, and then if it detects that you're looking at a handle that's already been recursed, it will bail?

[ccomp5950]

I've spent the last bit or so trying to reproduce this error and the only way I can is to purposefully create a circular requirement of scripts. Either a script requiring itself or a script requiring a script that requires the original script.

So in essence this bug is probably a duplicate of this: #21520

[johnbillion]

Agreed. Thanks for the feedback ccomp5950. Marking as dupe of #21520.