WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#30532 closed defect (bug) (fixed)

Twenty Fifteen: Improve style dependency loading

Reported by: ocean90 Owned by: iandstewart
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The main stylesheet should get Genericons and the Google webfonts as a dependency. The IE specific stylesheet doesn't include any styles for Genericons so the dependency is wrong in this case.

Attachments (2)

30532.patch (1.0 KB) - added by ocean90 6 years ago.
30532.1.diff (775 bytes) - added by iamtakashi 6 years ago.
Remove Genericon from the main stylesheet dependency.

Download all attachments as: .zip

Change History (13)

@ocean90
6 years ago

#1 @iandstewart
6 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 30692:

Twenty Fifteen: correct stylesheet dependencies.

Props ocean90, fixes #30532.

#2 @nacin
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Per #30678 this ticket needs to be reopened.

This ticket was mentioned in Slack in #core by nacin. View the logs.


6 years ago

#4 @ocean90
6 years ago

Fine with removing genericons. One line up we already have wp_enqueue_style( 'genericons', ….

@iamtakashi
6 years ago

Remove Genericon from the main stylesheet dependency.

This ticket was mentioned in Slack in #core-themes by lancewillett. View the logs.


6 years ago

#6 @lancewillett
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 30865:

Twenty Fifteen: remove Genericons as a dependency from loading the main stylesheet.

Props iamtakashi, fixes #30532.

#7 @lancewillett
6 years ago

In 30866:

Twenty Fourteen: remove Genericons as a dependency from loading the main stylesheet and IE-specific stylesheet. See #30532.

#8 @johnbillion
6 years ago

  • Keywords commit fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

#9 @johnbillion
6 years ago

In 30882:

Twenty Fifteen: remove Genericons as a dependency from loading the main stylesheet.

Merges [30865] to the 4.1 branch.

Props iamtakashi
See #30532.

#10 @johnbillion
6 years ago

In 30883:

Twenty Fourteen: remove Genericons as a dependency from loading the main stylesheet and IE-specific stylesheet.

Merges [30866] to the 4.1 branch.

See #30532.

#11 @johnbillion
6 years ago

  • Keywords commit fixed-major removed
  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.