Opened 10 years ago
Closed 10 years ago
#30540 closed defect (bug) (fixed)
Docblock for wp_get_nav_menu_to_edit in /wp-admin/includes/nav-menu.php incorrectly declares $menu_id param as string
Reported by: | dustyf | Owned by: | DrewAPicture |
---|---|---|---|
Milestone: | 4.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Menus | Keywords: | has-patch |
Focuses: | docs | Cc: |
Description
The $menu_id param in wp_get_nav_menu_to_edit in file, /wp-admin/includes/nav-menu.php, should be declared as an int instead of a string. The parameter is declaring an ID of a specific menu that will be edited.
Attachments (2)
Change History (6)
#2
@
10 years ago
- Milestone changed from Awaiting Review to 4.1
- Version trunk deleted
Hi Jaimie, thanks for the patch!
#3
@
10 years ago
Hi Jaimie,
Just two things to note for future reference that I've adjusted in 30540.2.patch:
- The parameter is optional so we need to mark it as such with the default value
- Patches should be generated from the project root directory
Note: See
TracTickets for help on using
tickets.
param changed from string to int