WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#30545 closed defect (bug) (fixed)

Twenty Fifteen: Similar strings

Reported by: pavelevap Owned by: iandstewart
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Bundled Theme Keywords: needs-patch
Focuses: Cc:

Description

There are 2 similar strings, do we need them both (see patch)? Part of removed string also does not make sense "will become the header", better is "will be applied to the header", I guess.

And other minor note: One of these string is shown twice in Color section for Customizer (for both settings), maybe once would be enough (as section description)?

Attachments (5)

2015_customizer_similar_strings.patch (1.4 KB) - added by pavelevap 6 years ago.
30545.png (47.4 KB) - added by DrewAPicture 6 years ago.
w/ patch
30545-customizer-text.diff (1.3 KB) - added by iandstewart 6 years ago.
Updating customizer labels for clarity.
30545.3.diff (3.6 KB) - added by iamtakashi 6 years ago.
with changes in POT file.
30543.4.diff (4.4 KB) - added by iamtakashi 6 years ago.
Refreshed patch

Download all attachments as: .zip

Change History (15)

#1 @lancewillett
6 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.1

This ticket was mentioned in Slack in #core-themes by iandstewart. View the logs.


6 years ago

#3 @iandstewart
6 years ago

I'm kind of a fan of "will become" because it suggests that things may seem to move around and change but the patch reads better. Still a fan of duplicating the message for clarity though.

#4 @iandstewart
6 years ago

  • Keywords commit added

@DrewAPicture
6 years ago

w/ patch

This ticket was mentioned in Slack in #core-themes by drew. View the logs.


6 years ago

#6 @iandstewart
6 years ago

  • Keywords commit removed

Applied to the header on small screens and the sidebar on wide screens.

Shorter. Matches the header-sidebar order in the label.

#7 @iandstewart
6 years ago

  • Keywords needs-refresh added

If we update this, we'd need to update the .pot as well. Any more thoughts on this ticket? It needs a refresh, either way.

#8 @iamtakashi
6 years ago

I prefer the shorter one. Longer descriptions make the option look complicated than what it really is. I think users will just try to see how the option work in the iframe anyway. That's the beauty of Customizer :)

@iandstewart
6 years ago

Updating customizer labels for clarity.

@iamtakashi
6 years ago

with changes in POT file.

#9 @johnbillion
6 years ago

  • Keywords needs-patch added; has-patch needs-refresh removed

This string appears at the bottom of twentyfifteen_customize_register() too.

@iamtakashi
6 years ago

Refreshed patch

#10 @iandstewart
6 years ago

  • Owner set to iandstewart
  • Resolution set to fixed
  • Status changed from new to closed

In 30741:

Twenty Fifteen: updating customizer label text for more clarity.

Props iamtakashi, fixes #30545.

Note: See TracTickets for help on using tickets.