Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #30566, comment 12


Ignore:
Timestamp:
12/02/2014 10:34:53 PM (10 years ago)
Author:
nerrad
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #30566, comment 12

    initial v1  
    1 I returned an empty string because in the original `http://` is a string.  In my opinion returning the same data type is better and since the caller is expectation a string to be returned...
     1I returned an empty string because in the original `http://` is a string.  In my opinion returning the same data type is better and since the caller is expecting a string to be returned...
    22
    33Splitting the unit test in two works, and yeah you're right about the unit tests not needing new sites.  I'll implement.