Context Navigation

← Previous Ticket
Next Ticket →

#30576 closed enhancement (fixed)

Include $expiration argument for the pre_set_transient_* filter

Reported by:	mgibbs189	Owned by:	johnbillion
Priority:	normal	Milestone:	4.2
Component:	Options, Meta APIs	Version:	3.0
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

This appears to be the only set_transient() filter that doesn't include the $expiration argument.

Attachments (2)

option.php.patch (752 bytes ) - added by mgibbs189 12 years ago.
option.php.2.patch (968 bytes ) - added by mgibbs189 12 years ago.

Download all attachments as: .zip

Change History (13)

@mgibbs189
12 years ago

Attachment option.php.patch added

#1 @DrewAPicture
12 years ago

Keywords has-patch needs-docs added

Hi mgibbs,

We'll also need to add an @param line for the new parameter, as well as add an entry to the changelog, e.g.

* @since 4.2.0 Added `$expiration` parameter.

@mgibbs189
12 years ago

Attachment option.php.2.patch added

#2 @mgibbs189
12 years ago

@DrewAPicture sure, updated patch added.

#3 @mgibbs189
12 years ago

Keywords needs-docs removed

#4 @DrewAPicture
12 years ago

Milestone Awaiting Review → Future Release

This is obviously too late for 4.1 consideration. option.php.2.patch looks pretty good.

#5 @mgibbs189
12 years ago

That's fine. Thanks for your help

#6 @johnbillion
12 years ago

Version trunk → 3.0

#7 @mgibbs189
12 years ago

@johnbillion version 3.0?

#8 @johnbillion
11 years ago

Focuses docs added
Milestone Future Release → 4.2

#9 @johnbillion
11 years ago

Owner set to johnbillion
Resolution → fixed
Status new → closed

In 31414:

Add $expiration as a parameter to the pre_set_transient_{$transient} filter.

Props mgibbs189
Fixes #30576

#10 @johnbillion
11 years ago

@mgibbs189 The version field on Trac indicates the first version of WordPress which is affected by the issue.

Last edited 11 years ago by johnbillion (previous) (diff)

#11 @DrewAPicture
11 years ago

Focuses docs removed

Note: See TracTickets for help on using tickets.

Download in other formats:

Make WordPress Core

Context Navigation

#30576 closed enhancement (fixed)

Include $expiration argument for the pre_set_transient_* filter

Description

Attachments (2)

Change History (13)

@mgibbs189 12 years ago

#1 @DrewAPicture 12 years ago

@mgibbs189 12 years ago

#2 @mgibbs189 12 years ago

#3 @mgibbs189 12 years ago

#4 @DrewAPicture 12 years ago

#5 @mgibbs189 12 years ago

#6 @johnbillion 12 years ago

#7 @mgibbs189 12 years ago

#8 @johnbillion 11 years ago

#9 @johnbillion 11 years ago

#10 @johnbillion 11 years ago

#11 @DrewAPicture 11 years ago

Download in other formats:

@mgibbs189
12 years ago

#1 @DrewAPicture
12 years ago

@mgibbs189
12 years ago

#2 @mgibbs189
12 years ago

#3 @mgibbs189
12 years ago

#4 @DrewAPicture
12 years ago

#5 @mgibbs189
12 years ago

#6 @johnbillion
12 years ago

#7 @mgibbs189
12 years ago

#8 @johnbillion
11 years ago

#9 @johnbillion
11 years ago

#10 @johnbillion
11 years ago

#11 @DrewAPicture
11 years ago