WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#30576 closed enhancement (fixed)

Include $expiration argument for the pre_set_transient_* filter

Reported by: mgibbs189 Owned by: johnbillion
Milestone: 4.2 Priority: normal
Severity: normal Version: 3.0
Component: Options, Meta APIs Keywords: has-patch
Focuses: Cc:

Description

This appears to be the only set_transient() filter that doesn't include the $expiration argument.

Attachments (2)

option.php.patch (752 bytes) - added by mgibbs189 5 years ago.
option.php.2.patch (968 bytes) - added by mgibbs189 5 years ago.

Download all attachments as: .zip

Change History (13)

#1 @DrewAPicture
5 years ago

  • Keywords has-patch needs-docs added

Hi mgibbs,

We'll also need to add an @param line for the new parameter, as well as add an entry to the changelog, e.g.

* @since 4.2.0 Added `$expiration` parameter.

#2 @mgibbs189
5 years ago

@DrewAPicture sure, updated patch added.

#3 @mgibbs189
5 years ago

  • Keywords needs-docs removed

#4 @DrewAPicture
5 years ago

  • Milestone changed from Awaiting Review to Future Release

This is obviously too late for 4.1 consideration. option.php.2.patch looks pretty good.

#5 @mgibbs189
5 years ago

That's fine. Thanks for your help

#6 @johnbillion
5 years ago

  • Version changed from trunk to 3.0

#7 @mgibbs189
5 years ago

@johnbillion version 3.0?

#8 @johnbillion
5 years ago

  • Focuses docs added
  • Milestone changed from Future Release to 4.2

#9 @johnbillion
5 years ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 31414:

Add $expiration as a parameter to the pre_set_transient_{$transient} filter.

Props mgibbs189
Fixes #30576

#10 @johnbillion
5 years ago

@mgibbs189 The version field on Trac indicates the first version of WordPress which is affected by the issue.

Last edited 5 years ago by johnbillion (previous) (diff)

#11 @DrewAPicture
5 years ago

  • Focuses docs removed
Note: See TracTickets for help on using tickets.