Twenty Fifteen: Translators comments missing from GlotPress

[netweb]

Translators comments missing from GlotPress:

Example:

• String: ​https://translate.wordpress.org/projects/wp/dev/twentyfifteen/en-au/default?filters[original_id]=201487
• Source: ​http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentyfifteen/functions.php#L184

Results:

• Only the context is displayed Context: Add new subset (greek, cyrillic, devanagari, vietnamese)

Expected:

• The context Context: Add new subset (greek, cyrillic, devanagari, vietnamese) AND the translators comment Translators: To add an additional character subset specific to your language, translate this to 'greek', 'cyrillic', 'devanagari' or 'vietnamese'. Do not translate into your own language. to be displayed.`

An example of a 'Working Translators Comment':

• String: ​https://translate.wordpress.org/projects/wp/dev/twentyfifteen/en-au/default?filters[status]=either&filters[original_id]=201471&filters[translation_id]=9654285
• Source: ​http://core.trac.wordpress.org/browser/trunk/wp-content/themes/twentyfifteen/inc/template-tags.php#L237

[netweb]

In the 30603.diff patch I have switched the translators comment to a single line rather than multiline, I am not 100% sure this is the correct fix, "I think" it is though ;)

[azaozz]

Thinking the error is the capital T. There are couple of multi-line translators: comments that seem to work fine?

[ocean90]

Replying to azaozz:

Thinking the error is the capital T.

That's not the error because the i18n tool is using stripos() here, see trunk/tools/i18n/extract.php@29563#L174​.

[DrewAPicture]

In the i18n tools it seems to me that there isn't a mechanism for handling inner-comment lines only beginning with a space and an asterisk: ' *'. That could be the issue with the comments not getting matched up.

FWIW, in my search I could only find five instances where translator comments were multi-line, four of them in TwentyFifteen and one of them in TwentyFourteen. I'd suggest lowercasing the 'T' for consistency and moving to single-line comments as a precaution.

Adversely, we could update the RegEx in find_function_calls() to handle multi-line comments. I'm thinking that would be a good later-addition at this juncture.

[DrewAPicture]

30603.2.diff​ lowercases the 'T'.

[iandstewart]

In 30790:

Twenty Fifteen: moving to a single line for tranlator comments to prevent them being missed in i18n tools.

Props netweb, DrewAPicture, fixes #30603.

[netweb]

The twentyfifteen.pot needs updating after r30790

[iandstewart]

In 30811:

Twenty Fifteen: updating the .pot to reflect changes in r30790.

Props iamtakashi, fixes #30603.

[netweb]

Thanks y'all, working as intended now :)

• String: ​https://translate.wordpress.org/projects/wp/dev/twentyfifteen/en-au/default?filters[original_id]=201487

And to follow up for those following along and future reference:

Replying to ocean90:
Replying to azaozz:

Thinking the error is the capital T.

That's not the error because the i18n tool is using stripos() here, see trunk/tools/i18n/extract.php@29563#L174​

This's correct stripos() looks for /* or // on a new line, nothing to do with the capitalisation of the letter T.

[SergeyBiryukov]

In 30790:

Twenty Fifteen: moving to a single line for tranlator comments to prevent them being missed in i18n tools.

For the record, looks like multiple lines were not the issue here, an empty line after /* was. See [25908].

[SergeyBiryukov]

Follow-up: #30972

[ocean90]

In 31500:

Revert [30790] and update POT file for Twenty Fifteen.

see #30972, #30603.

[ocean90]

In 31501:

Update POT file for Twenty Fourteen.

props SergeyBiryukov.
see #30972, #30603.