WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #30603, comment 5


Ignore:
Timestamp:
12/07/2014 09:38:15 PM (7 years ago)
Author:
DrewAPicture
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #30603, comment 5

    initial v1  
    11In the i18n tools it seems to me that there isn't a mechanism for handling inner-comment lines only beginning with a space and an asterisk: ' *'. That could be the issue with the comments not getting matched up.
    22
    3 FWIW, in my search I could only find five instances where translator comments were multi-line, four of them in TwentyFifteen and one of them in TwentyFourteen. I'd suggest lowercasing the 'T' for consistency and moving to single-long comments as a precaution.
     3FWIW, in my search I could only find five instances where translator comments were multi-line, four of them in TwentyFifteen and one of them in TwentyFourteen. I'd suggest lowercasing the 'T' for consistency and moving to single-line comments as a precaution.
    44
    55Adversely, we could update the RegEx in `find_function_calls()` to handle multi-line comments. I'm thinking that would be a good later-addition at this juncture.