WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 22 months ago

#30605 closed defect (bug) (fixed)

Typographically incorrect usage of hyphens

Reported by: pixolin Owned by: wonderboymusic
Milestone: 4.4 Priority: normal
Severity: trivial Version: 4.0
Component: Help/About Keywords: has-patch
Focuses: docs Cc:

Description

wp-admin/index.php, lines 67 to 77 has text with hyphens that should be replaced by — (as e.g. used in https://core.trac.wordpress.org/browser/trunk/src/wp-admin/update-core.php#L484) to keep typography consistent.

Attachments (3)

index.php (5.9 KB) - added by pixolin 2 years ago.
wp-admin/index.php with replaced hyphens
index.diff (2.8 KB) - added by pixolin 2 years ago.
patch for wp-admin/index.php
30605.diff (26.3 KB) - added by pixolin 2 years ago.
Replacing hyphens with — for better typographically consistence

Download all attachments as: .zip

Change History (13)

@pixolin
2 years ago

wp-admin/index.php with replaced hyphens

#1 @pixolin
2 years ago

  • Severity changed from normal to trivial

#2 @ocean90
2 years ago

Can you please provide a diff file instead of the patched file itself? See https://make.wordpress.org/core/handbook/working-with-patches/ for help.

@pixolin
2 years ago

patch for wp-admin/index.php

#3 @pixolin
2 years ago

I feel a little helpless here, not having provided any patches before. I ran svn diff > index.diff in my terminal and uploaded that file. Was that correct?

#4 @ocean90
2 years ago

  • Keywords has-patch added

Looks good, thanks. :)

#5 @kpdesign
2 years ago

  • Component changed from General to Help/About
  • Focuses docs added

#6 follow-up: @SergeyBiryukov
2 years ago

There are more instances in the following files:

wp-admin/edit-form-advanced.php
wp-admin/edit-tags.php
wp-admin/index.php
wp-admin/network/site-info.php
wp-admin/network/site-settings.php
wp-admin/network/site-themes.php
wp-admin/network/site-users.php

@pixolin
2 years ago

Replacing hyphens with — for better typographically consistence

#7 in reply to: ↑ 6 @pixolin
2 years ago

Replying to SergeyBiryukov:

Uploaded a new patch file to exchange hyphens with — for more consistency in typography.
Patch covers all files mentioned by Sergey.

wp-admin/edit-form-advanced.php
wp-admin/edit-tags.php
wp-admin/index.php
wp-admin/network/site-info.php
wp-admin/network/site-settings.php
wp-admin/network/site-themes.php
wp-admin/network/site-users.php

#8 @helen
2 years ago

  • Version changed from trunk to 4.0

#9 @wonderboymusic
22 months ago

  • Milestone changed from Awaiting Review to 4.4

#10 @wonderboymusic
22 months ago

  • Owner set to wonderboymusic
  • Resolution set to fixed
  • Status changed from new to closed

In 33641:

Replace some hyphens with —s in admin help tabs.

Props pixolin.
Fixes #30605.

Note: See TracTickets for help on using tickets.