Opened 10 years ago
Closed 9 years ago
#30605 closed defect (bug) (fixed)
Typographically incorrect usage of hyphens
Reported by: | pixolin | Owned by: | wonderboymusic |
---|---|---|---|
Milestone: | 4.4 | Priority: | normal |
Severity: | trivial | Version: | 4.0 |
Component: | Help/About | Keywords: | has-patch |
Focuses: | docs | Cc: |
Description
wp-admin/index.php, lines 67 to 77 has text with hyphens that should be replaced by — (as e.g. used in https://core.trac.wordpress.org/browser/trunk/src/wp-admin/update-core.php#L484) to keep typography consistent.
Attachments (3)
Change History (13)
#2
@
10 years ago
Can you please provide a diff file instead of the patched file itself? See https://make.wordpress.org/core/handbook/working-with-patches/ for help.
#3
@
10 years ago
I feel a little helpless here, not having provided any patches before. I ran svn diff > index.diff
in my terminal and uploaded that file. Was that correct?
#6
follow-up:
↓ 7
@
10 years ago
There are more instances in the following files:
wp-admin/edit-form-advanced.php wp-admin/edit-tags.php wp-admin/index.php wp-admin/network/site-info.php wp-admin/network/site-settings.php wp-admin/network/site-themes.php wp-admin/network/site-users.php
#7
in reply to:
↑ 6
@
10 years ago
Replying to SergeyBiryukov:
Uploaded a new patch file to exchange hyphens with — for more consistency in typography.
Patch covers all files mentioned by Sergey.
wp-admin/edit-form-advanced.php wp-admin/edit-tags.php wp-admin/index.php wp-admin/network/site-info.php wp-admin/network/site-settings.php wp-admin/network/site-themes.php wp-admin/network/site-users.php
wp-admin/index.php with replaced hyphens