Media: toolbar not restored after leaving iframe-based content

[mcsf]

Observable on WPCOM, could affect sites that extend the Media Manager. Steps to reproduce:

• Go to /wp-admin/post-new.php
• Select Insert Media
• Once the Media modal loads, select, if you have any, a view from the sidebar that loads an iframe. Such a view will replace the whole content + toolbar area. You might see a fake toolbar here if the iframe imitates it.
• Again from the sidebar, select, if you have any, a custom view (i.e., not Insert Media or Create Gallery) that does not load an iframe.

Expected: the bottom toolbar, containing an Insert button, should be visible.
Observed: the toolbar “disappears” when going from the iframe-based view to the non-iframe-based view.

I used quotes because the toolbar isn’t actually disappearing—it’s actually not reappearing after we leave the iframe.

I'm attaching a working patch for this.

cc @dd32 @azaozz @pento

[azaozz]

Thanks @mcsf for the patch.

Looks good to me as we are adding the hide-toolbar class in iframeContent() on creating the iframe, so we should be removing it too.

[azaozz]

In 30780:

Media: ensure the toolbar is shown after leaving iframe-based content. Props mcsf, fixes #30608.

[ocean90]

In 30792:

Fix JSHint error introduced in [30780].

see #30608.