WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#30612 closed defect (bug) (fixed)

Avoid using <code> HTML tags inside of translatable string

Reported by: ramiy Owned by: boonebgorges
Milestone: 4.1 Priority: normal
Severity: normal Version: 4.1
Component: Query Keywords: has-patch i18n-change
Focuses: Cc:

Description

See ticket #25834, comment 31, and changeset [30300].

Basically, we should not use <code> tags inside of translatable string.

But one string was missed.

This patch fixes the string.

Attachments (1)

30612.patch​ (767 bytes) - added by ramiy 6 years ago.

Download all attachments as: .zip

Change History (6)

@ramiy
6 years ago

#1 @ramiy
6 years ago

  • Keywords has-patch added

This ticket was mentioned in ​Slack in #core by boone. ​View the logs.
6 years ago

#3 follow-up: @boonebgorges
6 years ago

  • Keywords i18n-change added
  • Milestone changed from Awaiting Review to 4.1

Thanks for the patch.

#4 @boonebgorges
6 years ago

  • Owner set to boonebgorges
  • Resolution set to fixed
  • Status changed from new to closed

In 30751:

Remove <code> tags from translatable string in WP_Date_Query.

This was missed in [30300]. See #25834.

Props ramiy.
Fixes #30612.

#5 in reply to: ↑ 3 @ramiy
6 years ago

Replying to boonebgorges:

Thanks for the patch.

I have one more patch fixing 4 strings. see #30614.

Note: See TracTickets for help on using tickets.