Remove <code> tags from few more translatable string

[ramiy]

See ticket #30612.

I found few more strings that use <code> tags inside of translatable string. This patch fixes the string.

Remove <code> tags from translatable string

[iseulde]

has-patch 4.2-early so moving to 4.2.

[DrewAPicture]

Patch still applies. Looks like the second change in general-template.php modifies a commented-out line. Maybe we should just remove the line in that case:

//_deprecated_argument( __FUNCTION__, '2.2', sprintf( __('The %s option is deprecated for the family of <code>bloginfo()</code> functions.' ), '<code>' . $show . '</code>' ) . ' ' . sprintf( __( 'Use the %s function instead.' ), '<code>is_rtl()</code>'  ) );

[SergeyBiryukov]

I think <code>%s</code> actually provides some context in the first two strings. If we're removing it, we should probably add a translator's comment for %s there as well.

@nacin: Looking at [14360], the intention was to deprecate get_bloginfo( 'text_direction' ) in favor of is_rtl(). Not sure why it was commented out in that commit. Should we uncomment it now?

[nacin]

I have no idea. Probably? :-)

[DrewAPicture]

translator comments

[DrewAPicture]

Replying to SergeyBiryukov:

I think <code>%s</code> actually provides some context in the first two strings. If we're removing it, we should probably add a translator's comment for %s there as well.

In 30614.2.patch​, added translator comments for both in general-template.php.

@nacin: Looking at [14360], the intention was to deprecate get_bloginfo( 'text_direction' ) in favor of is_rtl(). Not sure why it was commented out in that commit. Should we uncomment it now?

Un-commented, fixed translator comment syntax for the second one.

[SergeyBiryukov]

I don't think a single translator comment can refer to multiple strings. We should probably merge "Use the %s option instead" with the preceding string (and use numbered placeholders there), as it's not used separately anywhere else.

[ocean90]

What Sergey says.

[ramiy]

Replying to SergeyBiryukov:

I don't think a single translator comment can refer to multiple strings. We should probably merge "Use the %s option instead" with the preceding string (and use numbered placeholders there), as it's not used separately anywhere else.

I agree. This should be one string.

[ramiy]

more elegant solution

[ocean90]

In 31899:

Remove <code> tags from translatable strings.

Uncomment deprecation notice for get_bloginfo( 'text_direction' ), see [14360].

props ramiy, DrewAPicture.
fixes #30614.